Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[subform] Validation of multiple subform. Fix Invalid argument supplied #25310

Merged
merged 1 commit into from
Jun 24, 2019
Merged

[subform] Validation of multiple subform. Fix Invalid argument supplied #25310

merged 1 commit into from
Jun 24, 2019

Conversation

ReLater
Copy link
Contributor

@ReLater ReLater commented Jun 24, 2019

Pull Request for Issue #25308

Summary of Changes

  • Add check for empty $value when a multiple subform without rows is sent through validation.

Testing Instructions

Expected result

  • No PHP warning

Actual result

PHP Warning: Invalid argument supplied for foreach() in \libraries\src\Form\Form.php on line 1558

@Quy
Copy link
Contributor

Quy commented Jun 24, 2019

I have tested this item ✅ successfully on ae39f01


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25310.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on ae39f01


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25310.

@ghost ghost removed the PR-staging label Jun 24, 2019
@ghost
Copy link

ghost commented Jun 24, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 24, 2019
@HLeithner HLeithner added this to the Joomla 3.9.9 milestone Jun 24, 2019
@HLeithner HLeithner merged commit 391f4a6 into joomla:staging Jun 24, 2019
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Jun 24, 2019
@HLeithner
Copy link
Member

thx

@ReLater ReLater deleted the patch-1 branch June 24, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants