Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the AppVeyor badge to project changes #25275

Merged
merged 2 commits into from
Jun 20, 2019

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Jun 19, 2019

Pull Request for Issue #25274 .

Summary of Changes

Correct the appveyor badge for staging:

  • Changed project/joomla/joomla-cms to project/release-joomla/joomla-cms.
  • Changed token.

Thanks to @blastoise186 for reporting that issue.

Testing Instructions

Check colour of the AppVeyor badge.

Click the AppVeyor badge on README.md.

Expected result

Colour fits to current build status for staging.

After click, AppVeyor activity shown for the latest commits.

https://github.com/richard67/joomla-cms/blob/patch-1/README.md

Actual result

Colour fits to build status in neolithicum.

AppVeyor activity shown for commits from 9 months ago and older.

https://github.com/joomla/joomla-cms/blob/staging/README.md

Documentation Changes Required

None.

@richard67
Copy link
Member Author

@blastoise186 Could you test this PR and mark the test result on https://issues.joomla.org/? You can use the links in the description for testing.

@blastoise186
Copy link

sure, give me about 5 minutes

@blastoise186
Copy link

I have tested this item ✅ successfully on e38cf91

the AppVeyor Badge now correctly points to /release-joomla/joomla-cms as intended.

Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25275.

@Quy
Copy link
Contributor

Quy commented Jun 19, 2019

I have tested this item ✅ successfully on e38cf91


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25275.

@Quy
Copy link
Contributor

Quy commented Jun 19, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25275.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 19, 2019
@HLeithner HLeithner merged commit 24e1ef6 into joomla:staging Jun 20, 2019
@HLeithner
Copy link
Member

thx

@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Jun 20, 2019
@HLeithner HLeithner added this to the Joomla 3.9.9 milestone Jun 20, 2019
@richard67
Copy link
Member Author

Thanks

@richard67 richard67 deleted the patch-1 branch June 20, 2019 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants