-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Expanded feedback to add images and more control (fixes #222) #223
Conversation
The testing json, 'c-60' provided above is missing a closing bracket for _incorrectNotFinal._graphic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problems testing this but I've raised a couple of queries around the popup layout.
- Update text/image layout to 60/40 for right and left aligned images (for desktop view) - Stack text/image for mobile view - Update alignment selectors for consistency with other plugin popup alignment classes (Hotgraphic, Hotgrid etc) - Removed legacy alignment classes (line 53 onwards). I can't see that classes ever got appended to .notify__content for these to work. Both component level and feedback level _classes get applied to .notify only.
- for consistency where 'image' has been used elsewhere
I've just committed my suggestions to notify.less and notifyPopup.hbs. A couple of things to note:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected with FW v5.22.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
🎉 This PR is included in version 6.20.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
fixes #222
This behaviour is fully backward compatible if the old style of
_feedback
objects are used. The new style feedback can be used in the new AAT and if building by hand, it will not be supported in the classic AATNew
_feedback._correct
,_feedback._partlyCorrectNotFinal
,_feedback._partlyCorrectFinal
,_feedback._incorrectNotFinal
,_feedback._incorrectFinal
and for_items[].feedback
Removed
Fix
compare
can now be used as a boolean helperTesting
Requires
ref adaptlearning/adapt-contrib-tutor#79
Todo