Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Feedback image and generic text #222

Closed
guywillis opened this issue Mar 21, 2019 · 9 comments · Fixed by #223 or adaptlearning/adapt-contrib-tutor#79
Closed

Feature request: Feedback image and generic text #222

guywillis opened this issue Mar 21, 2019 · 9 comments · Fixed by #223 or adaptlearning/adapt-contrib-tutor#79
Assignees
Labels
enhancement New feature or request released

Comments

@guywillis
Copy link
Contributor

guywillis commented Mar 21, 2019

Feature request to support images, with alt text if required, in question feedback. Images should be able to mirror the question feedback text so there are correct, partly correct not / final, and incorrect not final versions.

If an image is defined, the layout of the text and image is split 60% / 40% in favour of the text. If no image is defined the text defaults to 100% width.

Allow generic feedback title for all forms of feedback with ability to override title per feedback state.

Schemas will also need to be updated.

Suggestion:

"_feedback": {
  "_title": "Generic title",
  "_correct": {
    "_title": "Optional, override, correct title",
    "body": "Correct feedback text",
    "_graphic": {
      "alt": "Alt text",
      "_src": "course/en/images/correct.png",
    }
  },
  "_partlyCorrect": {
    "_notFinal": {
      "_title": "Optional, override, partly correct not final title",
      "body": "Partly correct not final feedback text",
      "_graphic": {
        "alt": "Alt text",
        "_src": "course/en/images/partly-correct-not-final.png"
      }
    },
    "_final": {
      "_title": "Optional, override, partly correct final title",
      "body": "Partly correct final feedback text",
      "_graphic": {
        "alt": "Alt text",
        "_src": "course/en/images/partly-correct-final.png"
      }
    }
  },
  "_incorrect": {
    "_notFinal": {
      "_title": "Optional, override, incorrect not final title",
      "body": "Incorrect not final feedback text",
      "_graphic": {
        "alt": "Alt text",
        "_src": "course/en/images/incorrect-not-final.png"
      }
    },
    "_final": {
      "_title": "Optional, override, incorrect final title",
      "body": "Incorrect final feedback text",
      "_graphic": {
        "alt": "Alt text",
        "_src": "course/en/images/incorrect-final.png"
      }
    }
  }
}
@moloko
Copy link
Contributor

moloko commented Mar 21, 2019

do you also want to go for option-specific feedback images for those question components that support that functionality (MCQ & GCMQ)?

we could always leave for now and add if and when someone says they definitely need it

@guywillis
Copy link
Contributor Author

Ideally, yes. Get it all done in one fell swoop.

@guywillis
Copy link
Contributor Author

I had a stab a little while ago at the request in the enhancement/refactor branch in the Framework, MCQ, and Tutor plugins which could form the basis for the request.

Framework: adaptlearning/adapt_framework@181c13e

MCQ:
adaptlearning/adapt-contrib-mcq@175e4d5

Tutor:
adaptlearning/adapt-contrib-tutor@9c838b3

@guywillis
Copy link
Contributor Author

Updated original request to include generic feedback title + ability to override title per feedback state.

@oliverfoster
Copy link
Member

@guywillis is this still relevant?

@guywillis
Copy link
Contributor Author

The method described above to implement, maybe not. The underlying request, absolutely.

@oliverfoster
Copy link
Member

Thanks

@oliverfoster
Copy link
Member

add this to requirements adaptlearning/adapt_framework#2408

@oliverfoster oliverfoster changed the title Feature request: Question feedback images Feature request: Feedback image and generic text Mar 28, 2022
@oliverfoster oliverfoster transferred this issue from adaptlearning/adapt_framework Aug 17, 2022
@oliverfoster oliverfoster added enhancement New feature or request and removed feature request labels Aug 17, 2022
@oliverfoster oliverfoster reopened this Sep 26, 2022
github-actions bot pushed a commit that referenced this issue Oct 19, 2022
## [6.20.5](v6.20.4...v6.20.5) (2022-10-19)

### Fix

* Expanded feedback to add images and more control (fixes #222) (#223) ([b34d4c5](b34d4c5)), closes [#222](#222) [#223](#223)
@github-actions
Copy link

🎉 This issue has been resolved in version 6.20.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment