Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback altTitle not working #411

Closed
kirsty-hames opened this issue Jul 19, 2023 · 1 comment · Fixed by #428
Closed

Feedback altTitle not working #411

kirsty-hames opened this issue Jul 19, 2023 · 1 comment · Fixed by #428
Assignees
@joe-allen-89
Labels
accessibility bug Something isn't working released

Comments

@kirsty-hames
Copy link
Contributor

Subject of the issue

When setting component level altTitle and/or global altFeedbackTitle neither are used.

Your environment

  • FW v5.31.15
  • Tutor v4.5.8

Steps to reproduce

Note, I also tested this for GMCQ and Slider feedback to confirm it wasn't specific to MCQ.

Expected behaviour

When component _feedback.title is empty, _feedback.altTitle should be used (if set), or _globals._accessibility.altFeedbackTitle (if set).

Actual behaviour

When component _feedback.title is empty, regardless if _feedback.altTitle or _globals._accessibility.altFeedbackTitle is set, component displayTitle is used instead.
@kirsty-hames kirsty-hames added bug Something isn't working accessibility labels Jul 19, 2023
@swashbuck swashbuck mentioned this issue Aug 7, 2023
Open
@joe-allen-89 joe-allen-89 self-assigned this Aug 11, 2023
@joe-allen-89 joe-allen-89 mentioned this issue Aug 11, 2023
Merged
@joe-allen-89 joe-allen-89 linked a pull request Aug 11, 2023 that will close this issue
Fix: remove component diplayTitle and Title fallbacks for feedbackTitle #428
Merged
kirsty-hames pushed a commit that referenced this issue Aug 15, 2023
@joe-allen-89
Fix: remove component diplayTitle and Title fallbacks for feedbackTit…
44234a1 
…le (fixes #411)

* Fix: Feedback title to use altTitle if feedback title is empty.

* Fix: remove diplayTitle and title fallback fof feedbackTitle.
github-actions bot pushed a commit that referenced this issue Aug 15, 2023
@semantic-release-bot
Chore(release): 6.39.1
4019e82 
## [6.39.1](v6.39.0...v6.39.1) (2023-08-15)

### Fix

* remove component diplayTitle and Title fallbacks for feedbackTitle (fixes #411) ([44234a1](44234a1)), closes [#411](#411)
@oliverfoster
Copy link
Member

🎉 This issue has been resolved in version 6.39.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joe-allen-89 joe-allen-89

Labels
accessibility bug Something isn't working released
Projects
None yet
Milestone
No milestone
3 participants
@kirsty-hames @oliverfoster @joe-allen-89