Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: PartlyCorrect feedback fallback values #416

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Fix: PartlyCorrect feedback fallback values #416

merged 6 commits into from
Aug 1, 2023

Conversation

cahirodoherty-learningpool
Copy link
Contributor

Fixes #415

Fix

  • 'Partly Correct Not Final' feedback should fall back to 'Partly Correct Final' which in turn should fall back to 'Incorrect Final' as per instruction text

@oliverfoster
Copy link
Member

What do you reckon to this #421 ?

@cahirodoherty-learningpool cahirodoherty-learningpool merged commit c093556 into master Aug 1, 2023
github-actions bot pushed a commit that referenced this pull request Aug 1, 2023
@semantic-release-bot
Chore(release): 6.38.8
3f9b44d 
## [6.38.8](v6.38.7...v6.38.8) (2023-08-01)

### Fix

* PartlyCorrect feedback fallback values (#416) ([c093556](c093556)), closes [#416](#416) [#421](#421)
@oliverfoster
Copy link
Member

🎉 This PR is included in version 6.38.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@oliverfoster oliverfoster mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@ethan-lp ethan-lp ethan-lp approved these changes

@eleanor-heath eleanor-heath eleanor-heath approved these changes

Assignees

@cahirodoherty-learningpool cahirodoherty-learningpool

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feedback partly correct fallbacks not applying correctly
4 participants
@cahirodoherty-learningpool @oliverfoster @ethan-lp @eleanor-heath