Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Release i18next-shopify framework #9

Closed
wants to merge 14 commits into from

Conversation

mkevinosullivan and others added 14 commits June 21, 2023 14:10
This commit adds the `supportAutoExtraction` array of supported formats
and the `detectHardStrings` method from `GeneralFramework` to enable
hard-coded string extraction for react-i18next framework, without
needing the "general" framework to be enabled/loaded in the
`.vscode/settings.json` file.
This commit adds the i18next-shopify framework to the list of supported
frameworks. It is an extension of the React i18next framework, with some
configuration changes.

Also add i18next-shopify example app, including a pluralization example.
Derived keys (e.g., such as plurals) were being miscategorised as
missing in the usage report.  This commit checks if keys derived from
those found in the missing list (keys that are in use but considered
"not defined") are included in the list of idle keys (keys defined but
not considered in use), indicating that they are indeed defined and in
use.

Fixes lokalise#953
…ext_framework

Add extraction support to react-i18next framework
…ng_value

Display first available pluralization string if parent key of nested pluralization keys
…sted_pluralization_keys

Add support for "Go to Definition" for pluralization strings
Fixes usage report for non-missing derived keys
Derived keys (e.g., such as plurals) are being miscategorised as not
found in the Current File Panel report.  This commit checks if any
existing key paths match derived keys paths, and if so, includes them in
the list of in use key paths and removed from the "not found" list.

Fixes lokalise#959
…ort_derived_keys

Fixes Current File Panel report of not found keys
Chore: fix spelling (strings, variables) within code base
@trishrempel
Copy link
Author

Opened PR here: lokalise#970

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants