Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extraction support to react-i18next framework #951

Closed
wants to merge 1 commit into from
Closed

Add extraction support to react-i18next framework #951

wants to merge 1 commit into from

Conversation

mkevinosullivan
Copy link
Contributor

@mkevinosullivan mkevinosullivan commented Jun 22, 2023 •
edited
Loading

This commit adds the supportAutoExtraction array of supported formats and the detectHardStrings method from GeneralFramework to the ReactI18nextFramework, to enable hard-coded string extraction without needing the "general" framework to be enabled/loaded in the .vscode/settings.json file.

Now the configuration entry can simply be

{
  "i18n-ally.enabledFrameworks": ["react-i18next"],
}

instead of

{
  "i18n-ally.enabledFrameworks": [
      "react-i18next",
      "general"
    ],
}

Fixes #948

@mkevinosullivan
Add extraction support to react-i18next framework
7ee58be 
This commit adds the `supportAutoExtraction` array of supported formats
and the `detectHardStrings` method from `GeneralFramework` to enable
hard-coded string extraction for react-i18next framework, without
needing the "general" framework to be enabled/loaded in the
`.vscode/settings.json` file.
@mkevinosullivan mkevinosullivan force-pushed the kos/enable_extraction_on_reacti18next_framework branch from 8dd5c42 to 7ee58be Compare June 22, 2023 15:30
@mkevinosullivan mkevinosullivan mentioned this pull request Jun 22, 2023
Closed
This was referenced Jul 10, 2023
Merged
Closed
@terales terales closed this Jul 11, 2023
@terales
Copy link
Collaborator

terales commented Jul 11, 2023

Merged within #970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terales terales Awaiting requested review from terales terales is a code owner

@kibertoad kibertoad Awaiting requested review from kibertoad kibertoad is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hard-coded strings feature doesn't work if i18n-ally.enabledFrameworks is explicitly set to a single framework
2 participants
@mkevinosullivan @terales