Add extraction support to react-i18next framework #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpasiliao
approved these changes
Jun 21, 2023
trishrempel
approved these changes
Jun 21, 2023
dpasiliao
approved these changes
Jun 21, 2023
trishrempel
approved these changes
Jun 21, 2023
mkevinosullivan
force-pushed
the
kos/enable_extraction_on_reacti18next_framework
branch
from
f988632
to
773874b
Compare
This commit adds the `supportAutoExtraction` array of supported formats and the `detectHardStrings` method from `GeneralFramework` to enable hard-coded string extraction for react-i18next framework, without needing the "general" framework to be enabled/loaded in the `.vscode/settings.json` file.
mkevinosullivan
force-pushed
the
kos/enable_extraction_on_reacti18next_framework
branch
from
8dd5c42
to
7ee58be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
supportAutoExtractionarray of supported formats to enable hard-coded string extraction for react-i18next framework, along with a copy ofdetectHardStringsfrom theGeneralFrameworkclass.(Also removes some linting errors.)