Add i18next-shopify framework #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trishrempel
reviewed
Jun 20, 2023
trishrempel
approved these changes
Jun 20, 2023
mkevinosullivan
changed the base branch from
main
to
kos/enable_extraction_on_reacti18next_framework
mkevinosullivan
force-pushed
the
kos/add_i18next_shopify_framework
branch
from
836027b
to
ef19b97
Compare
dpasiliao
requested changes
Jun 21, 2023
trishrempel
approved these changes
Jun 21, 2023
dpasiliao
approved these changes
Jun 21, 2023
mkevinosullivan
force-pushed
the
kos/add_i18next_shopify_framework
branch
from
dd21ea2
to
134008a
Compare
trishrempel
reviewed
Jun 21, 2023
| @@ -0,0 +1,11 @@ | |||
| { | |||
| "title": "hello", | |||
| "description": { | |||
There was a problem hiding this comment.
Could you please add a pluralization key to one of these example files? That's where i18next-shopify diverges most from react-i18next, and it will be good to have for demoing and testing feature improvements.
There was a problem hiding this comment.
Done! See "count.one", "count.other" below, and there's usage in App.jsx
mkevinosullivan
force-pushed
the
kos/enable_extraction_on_reacti18next_framework
branch
2 times, most recently
from
8dd5c42
to
7ee58be
Compare
mkevinosullivan
force-pushed
the
kos/add_i18next_shopify_framework
branch
from
134008a
to
92cfeaa
Compare
mkevinosullivan
commented
Jun 22, 2023
| <div>{t("translation.description.part2")}</div> | ||
| {/* plain <Trans>, #423 */} | ||
| <Trans i18nKey="translation.description.part2">Fallback text</Trans> | ||
| <p>{t("translation.count", { count: 1 })}</p> |
There was a problem hiding this comment.
Until the pluralization PR is merged, this will still render as "{...}"
This commit adds the i18next-shopify framework to the list of supported frameworks. It is an extension of the React i18next framework, with some configuration changes. Also add i18next-shopify example app, including a pluralization example.
mkevinosullivan
force-pushed
the
kos/add_i18next_shopify_framework
branch
from
2bd2073
to
e933f63
Compare
trishrempel
changed the base branch from
kos/enable_extraction_on_reacti18next_framework
to
release/i18next-shopify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the i18next-shopify framework to the list of supported frameworks.
It is an extension of the React i18next framework, with some configuration changes.
(Modified duplicate of Donn's PR: lokalise#931)