Support "Go to Definition" for nested pluralization keys #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkevinosullivan
changed the title
This was referenced Jul 10, 2023
|
Merged within #970 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the support for displaying inline the first available pluralization key value of a nested locale configuration (#2), the "Go to Definition" functionality is unable to switch to the definition in the locale file, as is expected.
Fixes #952
This commit fixes that, and as a by-product, hovering over the key will display the various translations.
Before:
After:
NOTE
This is built on #950, which requires that to be approved and merged first.