merge of master into dev/emc #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cing the necessary functions with fms2_io_mod functions
…name when needed and removing unneccessary code in fv_io_mod
remove trailiing spaces
fixes missing argument in store_data for case where GFS_PHYS macro no…
add in test for do_cube_transform in fv_grid_tool::init_grid
fixes bug in regional bc time calculation in fv_tracer2d.F90
…use fms_mod, only: write_version_number now.
…2beta1 Removing a duplicate use statement of FMS function "write_version_number"
…, addressding Uriel's comments from PR#74
…ter_axis in fv_ada_nudge. Reintroducing flush function and updating namelist read in fv_diag_column
…ation Fms2 io implementation
Adding Issue Templates to Repository
…er resolving merge conflicts
Dev/gfdl updates being brought back to master
Formatted PDF and source files for FV3 documentation.
FV3 Documentation
bensonr
requested review from
XiaqiongZhou-NOAA,
DusanJovic-NOAA,
junwang-noaa,
lharris4 and
yangfanglin
|
The changes to tools/external_ic.F90 were not that extensive. For some reason the git system is really munging the comparison unless you ignore whitespace diffs. |
lharris4
approved these changes
Aug 11, 2021
| @@ -1583,9 +1162,11 @@ end subroutine read_namelist_fv_core_nml | |||
|
|
|||
| subroutine setup_update_regions | |||
There was a problem hiding this comment.
In a future release we might want to move this routine into fv_nesting.F90
|
Thanks. We can restore this functionality if there is a desire to do so;
but my understanding is that the tracer distributions on the nest and the
parent match each other closely enough that updating mass fields is
unnecessary.
Lucas
…On Thu, Aug 12, 2021 at 9:27 AM bensonr ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In model/fv_nesting.F90
<#128 (comment)>
:
> + !!! RENORMALIZATION UPDATE OPTION
+ if (neststruct%nestupdate /= 3 .and. neststruct%nestupdate /= 7 .and. neststruct%nestupdate /= 8) then
+
+ endif
+ !!! END RENORMALIZATION UPDATE
@lharris4 <https://github.com/lharris4> - empty if-test removed in
default master branch and pushed to this merge2emc branch
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#128 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMUQRVHJPW5B6CYRTIPPD2LT4PD5HANCNFSM5B63URPQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
|
@XiaqiongZhou-NOAA @junwang-noaa @yangfanglin @DusanJovic-NOAA - can you please take time to review |
This was referenced Aug 26, 2021
| ! check_nml_error, stdlog,write_version_number,set_domain, | ||
| ! mpp_clock_id, mpp_clock_begin, mpp_clock_end, CLOCK_SUBCOMPONENT, | ||
| ! clock_flag_default, nullify_domain</td> | ||
| ! <td>file_exist, error_mesg, FATAL, check_nml_error, |
There was a problem hiding this comment.
file_exist is not used. Maybe it can be removed later
| @@ -545,7 +544,7 @@ subroutine fv_control_init(Atm, dt_atmos, this_grid, grids_on_this_pe, p_split) | |||
| #ifdef INTERNAL_FILE_NML | |||
There was a problem hiding this comment.
It looks to me the "INTERNAL_FILE_NML" IFDEFs were removed in this file, why do we still need it here?
junwang-noaa
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge of the latest work from GFDL's weather and climate dynamics group contained in default branch to dev/emc branch.
The work includes:
This update CHANGES ANSWERS.
How Has This Been Tested?
Besides exhaustive testing within the GFDL model framework, the UFS RTS has been run. The original runs of the UFS RTS were with certain parts of code reverted to reproduce the original baselines and understand what updates are responsible for changing answers. The only test(s) that fail are ones with gdas listed in their names as the data in the fv_core.res*.nc files appears to have been manipulated and the strict data integrity checks will terminate the run.
Checklist:
Please check all whether they apply or not