Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes bug in regional bc time calculation in fv_tracer2d.F90 #92

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

bensonr
Copy link
Contributor

@bensonr bensonr commented Apr 5, 2021

Description

Fixes a bug identified during the merge into dev/emc. The bug affects the time trigger for the regional bc updates.

Fixes # (issue)

How Has This Been Tested?

Tested via dev/emc merge.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix now gives the correct behavior. Earlier behavior would act to greatly extend the extrapolation, leading to potentially very large values of the incoming tracer (or perhaps even negatives), leading to artifacts and instability.

@laurenchilutti laurenchilutti merged commit 1b52517 into NOAA-GFDL:master Apr 5, 2021
@bensonr bensonr deleted the regional_time_fix branch April 5, 2021 17:46
climbfuji pushed a commit to climbfuji/GFDL_atmos_cubed_sphere that referenced this pull request Apr 24, 2024
GitFlow: Merge develop into main for release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants