Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/gfdl updates being brought back to master #108

Merged
merged 4 commits into from
Jun 10, 2021

Conversation

laurenchilutti
Copy link
Contributor

Description

Changes were needed in GFDL_tools/fv_ada_nudge.F90 and GFDL_tools/read_climate_nudge_data.F90 to correct compilation issues. driver/GFDL/atmosphere.F90 also required changes to correct compilation errors, and was at a different version in dev/gfdl than master, so I am bringing the dev/gfdl version back to master.

Fixes # (issue)

How Has This Been Tested?

These changes have been tested with climate models.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Always good to keep the drivers in sync.

@laurenchilutti laurenchilutti merged commit c32facc into NOAA-GFDL:master Jun 10, 2021
MicroTed pushed a commit to MicroTed/GFDL_atmos_cubed_sphere that referenced this pull request Sep 22, 2021
* Update suite_FV3_GFS_2017_fv3wam.xml
MicroTed pushed a commit to MicroTed/GFDL_atmos_cubed_sphere that referenced this pull request Sep 22, 2021
* Update suite_FV3_GFS_2017_fv3wam.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants