Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Issue Templates to Repository #105

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

laurenchilutti
Copy link
Contributor

Description

This PR adds Issue Templates to be used in the GFDL_atmos_cubed_sphere repository. There are 3 templates being included: feature request, support request, and bug report. These templates are derived from the FMS repository's issue templates.

Fixes # (issue)

How Has This Been Tested?

These templates can be tested by reviewers by navigating to my fork and creating test issues. You will have the choice of the 3 templates when you go to create an issue. I have tested this with 3 separate issues in my fork:
bug report test
feature request test
support request test test

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@lharris4
Copy link
Contributor

lharris4 commented Jun 1, 2021

Pardon my question, but how useful are these things, really? I see a lot of times the EMC submissions leave a lot of the boilerplate text in-place, and it's hard to scan the resulting issues/reports/requests for the important stuff.

@climbfuji
Copy link

Pardon my question, but how useful are these things, really? I see a lot of times the EMC submissions leave a lot of the boilerplate text in-place, and it's hard to scan the resulting issues/reports/requests for the important stuff.

Agreed. Same for ufs-weather-model, fv3atm, ... Unless we code managers are strict and reject PRs that don't have the templates filled out, it will add more confusion than it helps.

@lharris4
Copy link
Contributor

lharris4 commented Jun 1, 2021 via email

@bensonr
Copy link
Contributor

bensonr commented Jun 1, 2021

Not sure about the GitHub action, but with the issue templates in place, the time for being nice can be over. The code managers (Lauren and I) can reject any PR that doesn't have a corresponding issue along with any incomplete submission.

@climbfuji
Copy link

Not sure about the GitHub action, but with the issue templates in place, the time for being nice can be over. The code managers (Lauren and I) can reject any PR that doesn't have a corresponding issue along with any incomplete submission.

I will bring this up at the CCPP developer meeting today as well - would be nice to be consistent across the different repositories involved in the UFS.

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Jun 1, 2021 via email

@laurenchilutti laurenchilutti merged commit 80903f7 into NOAA-GFDL:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants