Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add in test for do_cube_transform in fv_grid_tool::init_grid #91

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

bensonr
Copy link
Contributor

@bensonr bensonr commented Apr 2, 2021

Description

Re-introduces a fix from dev/gfdl that should be in master. This update changes an else to an elseif conditional around a call to cube_transform in fv_grid_tools::init_grid. This function is an option for generating a stretched grid internally. Without this conditional, all internally generated grids run through this function and will not match a grid generated externally.

Fixes # (issue) - no issue created

How Has This Been Tested?

This has been tested as part of the merge of master -> dev/gfdl.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@lharris4
Copy link
Contributor

lharris4 commented Apr 3, 2021

Looks good. This version of the cube rotation fixes the problem in which tile 6 was upside down. I am hoping that this can eventually be supported by the external tools (something that FV3lib would help with).

Copy link
Contributor

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See my comment for my explanation of this new functionality.

@laurenchilutti laurenchilutti merged commit 5211985 into NOAA-GFDL:master Apr 5, 2021
@bensonr bensonr deleted the cube_xform_fix branch April 5, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants