Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump latex2unicode_2.12 from 0.2.6 to 0.3.0 #8639

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 4, 2022

Bumps latex2unicode_2.12 from 0.2.6 to 0.3.0.

Release notes

Sourced from latex2unicode_2.12's releases.

v0.3.0

What's Changed

New Contributors

Full Changelog: tomtung/latex2unicode@v0.2...v0.3.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [latex2unicode_2.12](https://github.com/tomtung/latex2unicode) from 0.2.6 to 0.3.0.
- [Release notes](https://github.com/tomtung/latex2unicode/releases)
- [Commits](https://github.com/tomtung/latex2unicode/commits/v0.3.0)

---
updated-dependencies:
- dependency-name: com.github.tomtung:latex2unicode_2.12
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@Siedlerchr
Copy link
Member

This will require some efforts to get it working with the modularity stuff...

@Siedlerchr Siedlerchr added the status: changes required Pull requests that are not yet complete label Apr 4, 2022
…om.github.tomtung-latex2unicode_2.12-0.3.0

* upstream/main:
  Remove obsolete comments
  Improve key generation (#8641)
  Refine search code (#8636)
  Fix import entry by id does not generate citation key (#8361)
  Update Gradle Wrapper from 7.4.1 to 7.4.2. (#8637)
  Bump hmarr/auto-approve-action from 2.1.0 to 2.2.0 (#8638)
@Siedlerchr Siedlerchr removed the status: changes required Pull requests that are not yet complete label Apr 5, 2022
@Siedlerchr
Copy link
Member

For some reason the export/import tests are failing.

@Siedlerchr
Copy link
Member

Failing tests might be due to the dash/minus issue. Need to check that

@Siedlerchr
Copy link
Member

For me this seems to fix #8522 under mac

Siedlerchr and others added 2 commits April 10, 2022 20:12
…om.github.tomtung-latex2unicode_2.12-0.3.0

* upstream/main:
  Fixed the inconsistent behavior for accents in search (#8640)
  Only show exit warning if running tasks will not be recovered (#8651)
@koppor
Copy link
Member

koppor commented Apr 10, 2022

I dived into the second test:

Expected:

grafik

Actual:

grafik

It seems that the new version is even more "smart" and converts non-typographic dashes to typographically correct dashes.

@Siedlerchr
Copy link
Member

@koppor This was probably this one tomtung/latex2unicode#15

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 11, 2022

A newer version of com.github.tomtung:latex2unicode_2.12 exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

build.gradle Outdated
modularity.patchModule("test", "fastparse_2.12-1.0.0.jar")
modularity.patchModule("test2", "fastparse-utils_2.12-1.0.0.jar")
modularity.patchModule("test3", "sourcecode_2.12-0.1.4.jar")
modularity.patchModule("fastparse", "sourcecode_2.13-0.2.3")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not completely sure, but the module name of sourcecode was fixed in com-lihaoyi/sourcecode#49.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yes works without the hack

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Than you should also be able to delete the files in /lib

Copy link
Member

@Siedlerchr Siedlerchr Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was not possible because scala does not yet implement the module system fully and when it is added as dependency, the automatic module naming was creating issues with illegal chars

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, the automatic module name should have actually fixed these problems.

…-0.3.0' of github.com:JabRef/jabref into dependabot/gradle/com.github.tomtung-latex2unicode_2.12-0.3.0

* 'dependabot/gradle/com.github.tomtung-latex2unicode_2.12-0.3.0' of github.com:JabRef/jabref:
  try version 0.3.1
  Save xmp data to new file and then copy it back (#8656)
  Adding notifications when writing metadata to pdfs (#8647)
…om.github.tomtung-latex2unicode_2.12-0.3.0

* upstream/main:
  Bump h2-mvstore from 2.1.210 to 2.1.212 in /buildSrc (#8665)
  Bump actions/setup-java from 2 to 3 (#8660)
  Bump hmarr/auto-approve-action from 2.2.0 to 2.2.1 (#8661)
  Bump unoloader from 7.3.0 to 7.3.2 (#8662)
  Bump antlr from 3.5.2 to 3.5.3 (#8663)
  Upgrade lucence to 9.x with proper JPMS (#8362)
@Siedlerchr Siedlerchr added the status: depends-on-external A bug or issue that depends on an update of an external library label Apr 12, 2022
@ThiloteE ThiloteE added the unicode unicode related issues label Apr 20, 2022
…om.github.tomtung-latex2unicode_2.12-0.3.0

* upstream/main: (59 commits)
  Bump postgresql from 42.3.3 to 42.3.4 (#8749)
  Bump org.openjfx.javafxplugin from 0.0.12 to 0.0.13 (#8748)
  Squashed 'buildres/csl/csl-locales/' changes from d834200f65..969d9567ac
  Squashed 'buildres/csl/csl-styles/' changes from 76b4268..25512a5
  Fix typo
  Restructure page intro
  Delete head_custom.html
  "master" -> "main"
  Change code highlighting theme
  Update devdoc theme
  Fixed faulty devdoc adr link
  Updated devdocs links
  Switch from GitBook to just-the-docs theme (#8734)
  Fix link to maintainers (#8731)
  New Crowdin updates (#8725)
  Update snapcraft URL
  Update bug_report.yml for v5.6
  Show development information\n\n+semver: minor
  Release v5.6
  Finish external
  ...
@calixtus calixtus merged commit 4718930 into main May 2, 2022
@calixtus calixtus deleted the dependabot/gradle/com.github.tomtung-latex2unicode_2.12-0.3.0 branch May 2, 2022 19:22
Jonathan-Oliveira pushed a commit to Jonathan-Oliveira/jabref that referenced this pull request May 7, 2022
Co-authored-by: Siedlerchr <siedlerkiller@gmail.com>
@koppor koppor mentioned this pull request May 8, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: depends-on-external A bug or issue that depends on an update of an external library unicode unicode related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants