Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dash - with minus − #15

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Replace dash - with minus − #15

merged 2 commits into from
Jul 21, 2021

Conversation

Atcold
Copy link
Contributor

@Atcold Atcold commented Jul 1, 2021

No description provided.

@Atcold
Copy link
Contributor Author

Atcold commented Jul 15, 2021

Any update on this?

@tomtung tomtung merged commit 0c2bab4 into tomtung:master Jul 21, 2021
@Atcold Atcold deleted the patch-1 branch July 21, 2021 20:11
@Atcold
Copy link
Contributor Author

Atcold commented Jul 21, 2021

Thanks for merging!

@Siedlerchr Siedlerchr mentioned this pull request Jul 28, 2021
Closed
tomtung added a commit that referenced this pull request Apr 5, 2022
@tomtung
Fix minus as sub- and super-script
fcea9d5 
Bug was introduced in #15
@tomtung tomtung mentioned this pull request Apr 5, 2022
Merged
tomtung added a commit that referenced this pull request Apr 5, 2022
@tomtung
Fix minus as sub- and super-script
44008c6 
Bug was introduced in #15
@Siedlerchr Siedlerchr mentioned this pull request Apr 10, 2022
Merged
@Siedlerchr
Copy link
Contributor

This is breaking all our tests. JabRef/jabref#8639
I would suggest to maybe only replace this in math mode?
Consider an author like: al-Khw{\\={a}}rizm{\\={i}} which previously was equal to al-Khwārizmī with a normal hyphen-dash (U+002D) and now it would be rendered with a minus sign (U+2212) which is wrong.

@tomtung
Copy link
Owner

tomtung commented Apr 11, 2022

Ah good point... Currently we "cheat" by not considering math v.s. non-math mode:

latex2unicode/src/main/scala/com/github/tomtung/latex2unicode/helper/Escape.scala

Line 12 in 9500bb2

"$" -> "", // Ignore $

To do this properly, we need to support parsing for math mode blocks, which is non-trivial. Maybe for now the best thing to do is to leave - as-is, and only escaping \textminus to the Unicode minus sign?

@Siedlerchr
Copy link
Contributor

Yes! I think this would be the easiest solution!

@Siedlerchr Siedlerchr mentioned this pull request Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Atcold @Siedlerchr @tomtung