Save xmp data to new file and then copy it back #8656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
added
the
status: ready-for-review
|
Looking good! Tried it and have not encountered any negative side-effects (yet)! 👍 Edit: What I did: I wrote XMP metadata to pdf. It worked. pdf file is not corrupted anymore and can be opened with foxitreader. Used exiftool to check if metadata was attached to the pdf: yes, it was. Tried importing the pdf into jabref (with and without grobid) and both import methods worked. Metadata was parsed. |
|
Thanks Christoph! |
… rights Co-authored-by: Christoph <siedlerkiller@gmail.com>
Siedlerchr
added a commit
that referenced
this pull request
Apr 11, 2022
…-0.3.0' of github.com:JabRef/jabref into dependabot/gradle/com.github.tomtung-latex2unicode_2.12-0.3.0 * 'dependabot/gradle/com.github.tomtung-latex2unicode_2.12-0.3.0' of github.com:JabRef/jabref: try version 0.3.1 Save xmp data to new file and then copy it back (#8656) Adding notifications when writing metadata to pdfs (#8647)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8655
No changelog necessary as this was most likely introduced in d98a603
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)