Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show exit warning if running tasks will not be recovered #8651

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

btut
Copy link
Contributor

@btut btut commented Apr 7, 2022

BackgroundTasks have a new flag that indicates whether JabRef will automatically resume/recover this task when relaunched. Such tasks should not interrupt a user shut-down.
I.e. indexing tasks, that will be continued when launching JabRef again.

Fixes #8468

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

btut added 2 commits April 7, 2022 12:24
I.e. indexing tasks, that will be continued when launching JabRef again.
@btut btut requested a review from koppor April 7, 2022 10:48
@btut btut self-assigned this Apr 7, 2022
@btut btut added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 7, 2022
@btut btut added this to the v5.6 milestone Apr 7, 2022
@calixtus calixtus merged commit 64ac2ae into main Apr 8, 2022
@calixtus calixtus deleted the recoverableTasks branch April 8, 2022 18:17
@calixtus
Copy link
Member

calixtus commented Apr 8, 2022

Thx

@tobiasdiez
Copy link
Member

Thanks!

Siedlerchr added a commit that referenced this pull request Apr 11, 2022
…om.github.tomtung-latex2unicode_2.12-0.3.0

* upstream/main:
  Fixed the inconsistent behavior for accents in search (#8640)
  Only show exit warning if running tasks will not be recovered (#8651)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancel index background worker when exiting JabRef
4 participants