Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine search code #8636

Merged
merged 6 commits into from
Apr 4, 2022
Merged

Refine search code #8636

merged 6 commits into from
Apr 4, 2022

Conversation

koppor
Copy link
Member

@koppor koppor commented Apr 3, 2022

This PR ports refactoring commits of #8206 to here. These are the commits before I began to add support for Lucene.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the search label Apr 3, 2022
@koppor
Copy link
Member Author

koppor commented Apr 3, 2022

Side comment: The search rules contain logic;, thus, they could/should IMHO be moved from model to logic. I can do it in this PR - or in a follow-up-PR (in 4625c05 (#8206) it was done)

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 3, 2022
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted almost only some rewording. Looks good to me.

@koppor koppor merged commit 432d743 into main Apr 4, 2022
@koppor koppor deleted the improve-tests branch April 4, 2022 21:02
@koppor koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 4, 2022
Siedlerchr added a commit that referenced this pull request Apr 5, 2022
* upstream/main:
  Remove obsolete comments
  Improve key generation (#8641)
  Refine search code (#8636)
  Fix import entry by id does not generate citation key (#8361)
  Update Gradle Wrapper from 7.4.1 to 7.4.2. (#8637)
  Bump hmarr/auto-approve-action from 2.1.0 to 2.2.0 (#8638)
  GitBook: [#57] test
  Citation keygen: Return vonPart if lastName is empty (#8634)
  Ensure SSL truststore is present at startup (#8631)
  Squashed 'buildres/csl/csl-styles/' changes from 6a7b708..21e2177 (#8632)
  Add more tests for FieldChange Class (#8614)
Siedlerchr added a commit that referenced this pull request Apr 5, 2022
…om.github.tomtung-latex2unicode_2.12-0.3.0

* upstream/main:
  Remove obsolete comments
  Improve key generation (#8641)
  Refine search code (#8636)
  Fix import entry by id does not generate citation key (#8361)
  Update Gradle Wrapper from 7.4.1 to 7.4.2. (#8637)
  Bump hmarr/auto-approve-action from 2.1.0 to 2.2.0 (#8638)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants