Deploy Checklist: New Expensify 2022-01-12

[OSBotify]

Release Version: 1.1.29-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Network: Retry requests that failed in flight #6567

  • QA
  • Accessibility

• Allow users to close their account #6641

  • QA
  • Accessibility

• Incorporate Add Bank Account / KYC checks into Send Money + Pay request flow #6659

  • QA
  • Accessibility

• Fix gsd mode pinned room not on the top #6849

  • QA
  • Accessibility

• Add get assistance page #6903

  • QA
  • Accessibility

• Allow App to Navigate to Last Visited Room On visiting with HOME url #6978

  • QA
  • Accessibility

• Report Details and Settings for User Created Policy Rooms #7028

  • QA
  • Accessibility

• [No QA] Convert ReportActionItemFragment into function component #7072

  • QA
  • Accessibility

• add regex for US account number #7101

  • QA
  • Accessibility

• [No QA] Fix Android deploy failures #7112

  • QA
  • Accessibility

• Add guidance on method binding for class components #7113

  • QA
  • Accessibility

• [No QA] Upgrade react native CLI to 6.2.0 #7117

  • QA
  • Accessibility

• [No QA] Temporarily remove getPullRequestsMergedBetween unit test #7119

  • QA
  • Accessibility

• [No QA] Commit Podfile.lock diff on main #7129

  • QA
  • Accessibility

• Add policy rooms to its own beta, and restrict this beta on dev #7130

  • QA
  • Accessibility

• submit changes via enter #7131

  • QA
  • Accessibility

• Fix Download links #7132

  • QA
  • Accessibility

• Add message user button #7135

  • QA
  • Accessibility

• Options default style fix #7136

  • QA
  • Accessibility

• [No QA] Don't rely on non-portable realpath #7137

  • QA
  • Accessibility

• Add stories for TextInput #7149

  • QA
  • Accessibility

• Give Storybook a facelift #7154

  • QA
  • Accessibility

• [No QA] Add separate assertions for deploy comments, fix bug #7161

  • QA
  • Accessibility

• Revert "Options default style fix" #7186

  • QA
  • Accessibility

• [No QA] Add jcenter back to build.gradle #7191

  • QA
  • Accessibility

• fix: Double slash issue for download link #7194

  • QA
  • Accessibility

Deploy Blockers:

• iOS - New chat - Contacts list can't be scrolled #7180
• Web - App downloading links - Clicking on mac OS link opens another tab #7189

cc @Expensify/applauseleads

[roryabraham]

As a reminder, please do not lock this checklist – we will do it as part of the QA of #6906

[roryabraham]

However, I do notice that #7112, which was CP'd in the last checklist, is not present in this checklist. This is a good sign that #4977 may at long last be fixed. 🤞

[mvtglobally]

@roryabraham It is late, we will start QA tomorrow. Should I wait for your Green light or we can start anytime?

[roryabraham]

Please wait for me to lock the checklist. Once I do that, feel free to begin QA. It will be tomorrow morning hopefully

[mvtglobally]

@roryabraham We are on standby, whenever you are ready

[Jag96]

Locking the checklist to bump the version to fix the deploy issues so we can test #6906 (comment)

[roryabraham]

@mvtglobally Belay that last comment – we'll ping you again when you're good to begin QA (not quite yet)

[roryabraham]

@mvtglobally Feel free to begin QA when ready

[mvtglobally]

Starting QA in few

[mvtglobally]

Checking off #6659 (comment)
#6903 is failing #7188
#7028 is failing due to #7055 is not fixed for Web and mWeb
Checking off #7101 as #7183 is closed.
#7132 is failing due to 7189
#7136 was reverted, Checking off

[Jag96]

Left a comment regarding #7188 here, I think we can pass QA for #6903 because the core issue exists on production and wasn't introduced by that PR.

[Jag96]

I also think we can remove #7201 (comment) from the deploy blocker list per that comment

[Jag96]

Looks like #7181 and #7055 had the Deploy blocker label removed as well, so taking those off the checklist

[Jag96]

Also removing #7182 from the checklist per #7182 (comment).

[mvtglobally]

Checking off #6903 based on #7144 (comment)
Checking off #6978. As per steps it needs URL change. We validated on Web and It can't be QA-ed on Android app
Checking off #7028 as #7055 is not a blocker
Checking off #7132 as #7189 was fixed
Checking off #7149 as #7187 not a blocker

[mvtglobally]

Only need to confirm #6567 to close this checklist.
Team was able to QA every platform but Desktop. Can someone check Desktop internally or we can check it off?

[Jag96]

@mvtglobally I can test it on desktop! Once that is done is accessibility the only thing we're waiting on? Is that still being tested?

[mvtglobally]

@Jag96 https://expensify.slack.com/archives/C01GTK53T8Q/p1641233170400600?thread_ts=1641231175.393100&cid=C01GTK53T8Q I think they can be checked off

[Jag96]

Great, #6567 passed QA on desktop so going to check off all the Accessibility boxes and close this!

[Jag96]