Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submit changes via enter #7131

Merged
merged 1 commit into from
Jan 11, 2022
Merged

submit changes via enter #7131

merged 1 commit into from
Jan 11, 2022

Conversation

thesahindia
Copy link
Member

@thesahindia thesahindia commented Jan 11, 2022

Details

Added the functionality to save changes on profile page and secondary login page on pressing enter

Fixed Issues

$ #7093

Tests

  • Verify that no errors appear in the JS console

QA Steps

  1. Open app
  2. Navigate to Settings > Profile
  3. Make any changes in the profile and hit "Enter" key
  4. Select "Add phone number"
  5. Enter Password
  6. Enter phone number and hit "Enter" key
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2022-01-11.at.11.58.58.PM.mp4

Mobile Web

Desktop

Screen.Recording.2022-01-12.at.12.45.55.AM.mov

iOS

Android

@thesahindia thesahindia requested a review from a team as a code owner January 11, 2022 19:11
@MelvinBot MelvinBot requested review from puneetlath and rushatgabhane and removed request for a team January 11, 2022 19:11
@rushatgabhane
Copy link
Member

@thesahindia could you please also add video for desktop app?

@thesahindia
Copy link
Member Author

@rushatgabhane, done.

@rushatgabhane
Copy link
Member

rushatgabhane commented Jan 11, 2022

Make any changes in the profile and hit "Enter" key (nothing happens)

Hi @thesahindia, your QA steps don't look right.
Kindly update them :)

Copy link
Member

@rushatgabhane rushatgabhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! No side effects on mobile, tests well and fixes the issue.
cc: @puneetlath

@thesahindia
Copy link
Member Author

@rushatgabhane, oops I just pasted the QA steps from the issue forgot to change that. Updated now :)

@puneetlath puneetlath merged commit e44706a into Expensify:main Jan 11, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @puneetlath in version: 1.1.27-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @puneetlath in version: 1.1.27-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @puneetlath in version: 1.1.27-3 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.29-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants