Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - App downloading links - Clicking on mac OS link opens another tab #7189

Closed
kavimuru opened this issue Jan 13, 2022 · 5 comments
Closed
Assignees
Labels
Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Jan 13, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #7132

Action Performed:

  1. Open https://staging.new.expensify.com
  2. Navigate to Settings > About > App download links > MacOS

Expected Result:

Option to download the app should appear

Actual Result:

Another new.dot tab opens

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • Mobile Web
  • iOS

Version Number: v1.1.29-2
Reproducible in staging?: Yes
Reproducible in production?: No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Issue was found when executing #7132

Bug5404960_Screen_Shot_2022-01-12_at_6 09 52_PM

Bug5404960_app.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Jan 13, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@parasharrajat
Copy link
Member

My PR is failing #7132. It's that damn // slash. Sending the fix now.

@parasharrajat
Copy link
Member

@Gonals #7194. CP it. Thanks.

@Jag96 Jag96 added Reviewing Has a PR in review and removed DeployBlockerCash This issue or pull request should block deployment labels Jan 13, 2022
@Jag96
Copy link
Contributor

Jag96 commented Jan 13, 2022

This has been fixed and is being deployed to staging, closing

@Jag96 Jag96 closed this as completed Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants