Add message user button #7135
Merged
Add message user button #7135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Expensify/design can I get your eyes on this one? Perhaps the spacing between |
|
I think it looks good personally, nice job! |
|
Thanks @shawnborton! @nickmurray47 all yours for the review! |
|
taking a look right now! |
54 tasks
|
🚀 Deployed to staging by @nickmurray47 in version: 1.1.27-6 🚀
|
|
🚀 Deployed to staging by @nickmurray47 in version: 1.1.27-7 🚀
|
|
possible regression? https://expensify.slack.com/archives/C01GTK53T8Q/p1642146678458100 |
s77rt
reviewed
May 26, 2023
Comment on lines
+155
to
+161
| <MenuItem | ||
| title={`${props.translate('common.message')}${details.displayName}`} | ||
| icon={Expensicons.ChatBubble} | ||
| onPress={() => Report.fetchOrCreateChatReport([props.session.email, details.login])} | ||
| wrapperStyle={styles.breakAll} | ||
| shouldShowRightIcon | ||
| /> |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Adds a message user button when seeing a user's profile.
Fixed Issues
$ #6661
Tests
Message <user>button and clicking it navigates you to the chat with that user.QA Steps
Steps above.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android