Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Temporarily remove getPullRequestsMergedBetween unit test #7119

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Jan 11, 2022

Details

Contributor PRs are failing unit tests because they do not have access to the repo secrets necessary for OSBotify to configure commit signing on the GitHub Actions runner. This PR should fix that temporarily removing the new failing test, pending a solution that doesn't require commit signing (or doesn't use actual GPG keys).

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/191675

Tests

None - only PR checks.

QA Steps

No QA.

Tested On

  • GitHub only

@roryabraham roryabraham self-assigned this Jan 11, 2022
@roryabraham roryabraham changed the title Remove GPG-signing from the unit tests [No QA] Remove GPG-signing from the unit tests Jan 11, 2022
@roryabraham roryabraham changed the title [No QA] Remove GPG-signing from the unit tests [No QA] Temporarily remove getPullRequestsMergedBetween unit test Jan 11, 2022
@roryabraham roryabraham marked this pull request as ready for review January 11, 2022 01:54
@roryabraham roryabraham requested a review from a team as a code owner January 11, 2022 01:54
@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team January 11, 2022 01:55
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging to unblock contributor PRs.

@Julesssss Julesssss merged commit 695dca4 into main Jan 11, 2022
@Julesssss Julesssss deleted the Rory-RevertFailingTest branch January 11, 2022 14:21
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.27-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.27-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.27-3 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.29-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants