-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to ignore directories #20
Comments
Could I get some more info about this? I think I could help, but not really sure what needs to be done exactly! |
@nevilgeorge, you'd need to check if the items in |
Should be done in |
Should this issue be closed now that sindresorhus/globby#46 is merged? |
Yes, just needs to be mentioned in the docs first. |
After testing it doesn't works because globby expand directory only for the That should works if we merge #288 though. But it probably something that should be fixed in globby? |
Yes. Can you open an issue over there? |
@issuehuntfest has funded $60.00 to this issue. See it on IssueHunt |
Is this still an issue? When testing locally using the latest version of XO ( {
...
"xo": {
"ignores": [
"dir"
]
},
...
} |
It was fixed by sindresorhus/globby#88 |
Didn't mean to closed before someone else confirms |
@pvdlg I think we need to update |
Just to be sure I fully understand.
which fast-glob wrongly interprets as a glob. But it's not related to use globs with windows backslashes such as:
Is that right? |
No, the inverse.
Yes, but I'm not super excited about having to do that manually in every library that uses |
I'm confused then. sindresorhus/del@01da91f#diff-168726dbe96b3ce427e7fedce31bb0bcR45 make the transformation only if the pattern is not a glob.
What I meant was to call |
Ah, your right. I was just confused by your wording:
It doesn't "wrongly interpret it as a glob", So yes, we're on the same page.
👍 |
eslint already supports ignoring patterns: https://eslint.org/docs/user-guide/configuring#ignorepatterns-in-config-files Setting |
This is fixed, we use this feature ourself Lines 108 to 114 in 5ff95ad
|
@fisker Do you know what commit fixed it? No worries if not, I just need to know who to give the bounty to. |
I don't know, but both |
@sindresorhus has rewarded $54.00 to @sindresorhus. See it on IssueHunt
|
I'll just put the bounty on some other issue then. |
joakimbeng/unistyle@4dfa6bc#commitcomment-13087626
Right now you have to do
directory/**
to ignore all files in a directory, but would be nice, and probably more natural, if you could ignore a directroy directly by usingdirectroy
.IssueHunt Summary
sindresorhus has been rewarded.
Backers (Total: $60.00)
Submitted pull Requests
Tips
The text was updated successfully, but these errors were encountered: