-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expandDirectories
option and set nodir
to true
by default
#46
Conversation
Ok, think I've nailed the performance regressions to the I'm wondering if we maybe should check if it's a glob using a regex before checking if it's a directory in the |
package.json
Outdated
@@ -53,6 +53,7 @@ | |||
], | |||
"dependencies": { | |||
"array-union": "^1.0.1", | |||
"dir-glob": "kevva/dir-glob#files", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that branch hasn't been merged to master
yet.
It's hard to reliably do that. Let's skip that for now. I don't want to deal with the headache of false negatives. |
expandDirectories
optionexpandDirectories
option and set nodir
to true
by default
Looks good! Glad we could finally include this in |
Noticed a pretty large performance regression so might have to fix that first before merging. Would've liked to to implement the login in
generateGlobTasks
but we'd need to introducegenerateGlobTasksSync
in that case.Fixes #33.