Fix expandDirectories and ignores option working together
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The appveyor seems unrelated |
sindresorhus
changed the title
expandDirectories and ignores option working together
sindresorhus
approved these changes
Sep 10, 2018
|
The relative path issue is due to #87. Maybe we could copy the code of |
|
@pvdlg I talked with the author of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across #62 when encountering an issue with relative paths + ignores. I tried fixing the relative path issue, but I've concluded that seems to be in
fast-glob, but it did seem to fix #62, so I'm PR-ing it and a failing test case for the relative pathFixes #62