Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cwd options not published on npm #7

Closed
pvdlg opened this issue Jul 13, 2018 · 4 comments
Closed

cwd options not published on npm #7

pvdlg opened this issue Jul 13, 2018 · 4 comments

Comments

@pvdlg
Copy link

pvdlg commented Jul 13, 2018

Following the README example:

$ mkdir -p fixtures/inner_folder
$ touch fixtures/inner_folder/index.js
dirGlob(['index.js', 'inner_folder'], {
	cwd: 'fixtures'
}).then(files => {
	console.log(files);
// => ['index.js', 'inner_folder'] and not ['index.js', 'inner_folder/**']
});
@pvdlg
Copy link
Author

pvdlg commented Jul 13, 2018

It seems it's because the code adding the cwd options wasn't released.
@kevva could you make a release with the last changes by any chance? Thanks a lot!

@pvdlg
Copy link
Author

pvdlg commented Jul 19, 2018

@kevva, really sorry to bother you again...Is there a chance you could release the last code from master on npm?
It's impacting globby users (sindresorhus/globby#87) and requires workarrounds on semantic-release...

@sindresorhus
Copy link
Contributor

It's published now.

@nambrot
Copy link

nambrot commented Jan 10, 2019

For anyone who might come here via pkg -> globby -> dir-glob, updating globby to 8.0.2 is probably the solution vercel/pkg#603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants