Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expandDirectories option should also apply to ignore patterns #62

Closed
pvdlg opened this issue Jan 20, 2018 · 2 comments · Fixed by #88
Closed

expandDirectories option should also apply to ignore patterns #62

pvdlg opened this issue Jan 20, 2018 · 2 comments · Fixed by #88
Labels
enhancement help wanted

Comments

@pvdlg
Copy link
Contributor

pvdlg commented Jan 20, 2018

expanddirectories applied only on the patterns in the patterns options. Directories defined in the ignore options should be expanded too.
@pvdlg pvdlg mentioned this issue Jan 20, 2018
Closed
@bdougherty
Copy link
Sponsor

@pvdlg are you going to try to fix this? If not, I will take a shot at it.

@pvdlg
Copy link
Contributor Author

pvdlg commented Jan 21, 2018

I was looking at it, but if you'd like to give it a shot, please go ahead.

bdougherty added a commit to bdougherty/globby that referenced this issue Jan 27, 2018
@bdougherty
Expand directories in ignore option (sindresorhus#62)
1b26b47
@bdougherty bdougherty mentioned this issue Jan 27, 2018
Closed
bdougherty added a commit to bdougherty/globby that referenced this issue Jan 27, 2018
@bdougherty
Expand directories in ignore option (sindresorhus#62)
96761c7
sindresorhus added a commit that referenced this issue Apr 18, 2018
@sindresorhus
Add failing test for #62
a25e960
@alexander-alvarez alexander-alvarez mentioned this issue Jul 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix expandDirectories and ignores option working together alexander-alvarez/globby
3 participants
@bdougherty @sindresorhus @pvdlg