Rename PointCloud -> PointCloudDataFrame on spatial branch #3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [c++] Extend some unit-test cases * code-review feedback
* `pkgdown.yml`: rm unused inputs neither [setup-pandoc@v1](https://github.com/r-lib/actions/blob/v1/setup-pandoc/action.yml) or [setup-r@v2](https://github.com/r-lib/actions/blob/v2/setup-r/action.yml) takes a `working-directory` input * bump `r-lib/actions/setup-pandoc` to `@v2` Current `@v1` is issuing deprecation warnings ([example](https://github.com/single-cell-data/TileDB-SOMA/actions/runs/11058461787))
…cases (#3069) * [c++] Extend some unit-test cases * code-review feedback * [c++] Expose custom domain for `libtiledbsoma` unit-test cases * complete connection to unit-test files * Fix Python tests, and straighten out logged method names * [c++] Expose custom domain for `libtiledbsoma` unit-test cases * complete connection to unit-test files * Fix Python tests, and straighten out logged method names * add a helpful comment [skip ci]
…3027) * [c++] Extend some unit-test cases * code-review feedback * [c++] Expose custom domain for `libtiledbsoma` unit-test cases * complete connection to unit-test files * Fix Python tests, and straighten out logged method names * Use pushdown domainish accessors at python UX level * code-review feedback Co-authored-by: Paul Hoffman <mojaveazure@users.noreply.github.com> * fix rebase * comment re code-review feedback [skip ci] --------- Co-authored-by: Paul Hoffman <mojaveazure@users.noreply.github.com>
…l datatypes (#3078) This updates the somacore version and adds the new spatial types to TileDB-SOMA as empty classes that throw `NotImplementedErrors`. It updates `Experiment` and `Measurement` to match the updated somacore API. Co-authored-by: Aaron Wolen <aaron@wolen.com> Co-authored-by: nguyenv <vivian@tiledb.com> Co-authored-by: John Kerl <kerl.john.r@gmail.com>
…rsion (#3086) * Update the encoding version to 1.1.0 * Update errors for valid soma types that are not yet implemented
- Update somacore to 1.0.19 - Rename `PointCloud` -> `PointCloudDataFrame` - Make `coordinate_space` property not optional in `MultiscaleImage`, `GeometryDataFrame`, and `PointCloudDataFrame`.
* [r] Implement missing `domain` argument to `DataFrame` `create` * devtools::document() * add a helpful comment [skip ci] * code-review feedback Co-authored-by: Paul Hoffman <mojaveazure@users.noreply.github.com> * typofix * update comment [skip ci] * DESCRIPTION and NEWS.md [skip ci] * devtools::document() * code-review feedback Co-authored-by: Paul Hoffman <mojaveazure@users.noreply.github.com> --------- Co-authored-by: Paul Hoffman <mojaveazure@users.noreply.github.com>
* can_resize/can_upgrade_shape * can_resize_soma_joinid
jp-dark
commented
Oct 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## spatial #3104 +/- ##
===========================================
+ Coverage 80.33% 80.40% +0.07%
===========================================
Files 49 49
Lines 5081 5089 +8
===========================================
+ Hits 4082 4092 +10
+ Misses 999 997 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nguyenv
approved these changes
Oct 1, 2024
nguyenv
added a commit
that referenced
this pull request
Oct 1, 2024
Merge in `main` and rename `PointCloud` -> `PointCloudDataFrame` --------- Co-authored-by: John Kerl <kerl.john.r@gmail.com> Co-authored-by: Ryan Williams <ryan.williams@tiledb.com> Co-authored-by: Paul Hoffman <mojaveazure@users.noreply.github.com> Co-authored-by: Aaron Wolen <aaron@wolen.com> Co-authored-by: nguyenv <vivian@tiledb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges
maininto thespatialbranch and completes the renaming ofPointCloudtoPointCloudDataFrame.