Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python/r/c++] Update allowed soma types and the metadata encoding version #3086

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Sep 27, 2024

Changes:

  • Update the SOMA metadata encoding to 1.1.0.
  • Update soma_type checks to describe spatial types as "not implemented" instead of "invalid".

Issue: #3045

@jp-dark
Copy link
Collaborator Author

jp-dark commented Sep 27, 2024

[sc-54178]

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.12%. Comparing base (95c2ba7) to head (3d090d8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3086      +/-   ##
==========================================
+ Coverage   89.02%   89.12%   +0.09%     
==========================================
  Files          45       45              
  Lines        4284     4286       +2     
==========================================
+ Hits         3814     3820       +6     
+ Misses        470      466       -4     
Flag Coverage Δ
python 89.12% <50.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.12% <50.00%> (+0.09%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as "1" and "1.1.0" cover all the encoding versions 'in the wild' (which I believe is the case).

@jp-dark jp-dark merged commit baafa74 into main Sep 30, 2024
15 checks passed
@jp-dark jp-dark deleted the dark/update-encoding-version branch September 30, 2024 14:21
johnkerl added a commit that referenced this pull request Sep 30, 2024
* Use core 2.26.2 (#3096)

* [python/r/c++] Update allowed soma types and the metadata encoding version (#3086)

* Update the encoding version to 1.1.0
* Update errors for valid soma types that are not yet implemented

* replace deprecated `wheel.bdist_wheel` with `setuptools.command.bdist_wheel` (#3076)

* [c++] Add `SOMAMultiscaleImage` class (#3094)

Add `SOMAMultiscaleImage` to `libtiledbsoma`.

* [c++] Simplify internal API for dataframe-resizer

---------

Co-authored-by: Julia Dark <24235303+jp-dark@users.noreply.github.com>
Co-authored-by: Ryan Williams <ryan.williams@tiledb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants