Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Add --maxfail=50 to GHA pytest invocations #3034

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

ryan-williams
Copy link
Member

Mitigate excessive logspam on PRs where many tests fail.

Multiple GHAs recently have failed with a huge amount of logspam, such that my browser tab never finishes loading the page, or any of the logs.

Here's an example, from #3001; downloading its logs:

j=30280188276
gh run view -j $j --log > $j.txt

Shows 472k lines / 77MiB. It looks like 482 test failures, some of which output ≈700 lines each.

The PRs where I've seen this recently have generally involved changing Python or Typeguard versions; Typeguard issues can cause large numbers of test cases to fail very verbosely.

This gist has the first 10,000 lines from the example above:

gh run view -j $j --log | head -n 10000 | gist -opf $j.txt

mitigate excessive logspam on PRs where many tests fail
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (11d5396) to head (5bc1aa2).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3034      +/-   ##
==========================================
+ Coverage   89.64%   89.79%   +0.14%     
==========================================
  Files          40       40              
  Lines        4096     4096              
==========================================
+ Hits         3672     3678       +6     
+ Misses        424      418       -6     
Flag Coverage Δ
python 89.79% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.79% <ø> (+0.14%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@ryan-williams ryan-williams marked this pull request as ready for review September 23, 2024 19:47
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ryan-williams ryan-williams merged commit c58eef2 into main Sep 27, 2024
12 checks passed
@ryan-williams ryan-williams deleted the rw/gha branch September 27, 2024 14:33
@johnkerl johnkerl changed the title [python] add --maxfail=50 to GHA pytest invocations [python] Add --maxfail=50 to GHA pytest invocations Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants