Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Improve test-case field names for DataFrame #3067

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Sep 25, 2024

Issue and/or context: The names foo bar baz are giving me some context-switching headaches -- which one is the string again? This PR simply makes the names of the attributes say what they are.

Part of #2407 / [sc-51048].

@johnkerl johnkerl force-pushed the kerl/improve-sdf-test-field-names branch from 40c92ab to ba725a8 Compare September 26, 2024 13:30
@johnkerl
Copy link
Member Author

johnkerl commented Sep 27, 2024

@mojaveazure not bumping DESCRIPTION and NEWS.md since this has no user impact

@johnkerl johnkerl merged commit 0c97ce9 into main Sep 27, 2024
14 checks passed
@johnkerl johnkerl deleted the kerl/improve-sdf-test-field-names branch September 27, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants