[c++] Extend some unit-test cases for new shape #3068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3068 +/- ##
==========================================
+ Coverage 89.79% 89.94% +0.14%
==========================================
Files 41 41
Lines 4107 4107
==========================================
+ Hits 3688 3694 +6
+ Misses 419 413 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/ut-generate
branch
from
91f6ac1
to
470c088
Compare
johnkerl
force-pushed
the
kerl/ut-generate
branch
from
470c088
to
5321e89
Compare
nguyenv
reviewed
Sep 25, 2024
johnkerl
commented
Sep 25, 2024
| @@ -1422,11 +1422,6 @@ void SOMAArray::_set_current_domain_from_shape( | |||
| // Variant-indexed dataframes must use a separate path | |||
| _check_dims_are_int64(); | |||
|
|
|||
| if (_get_current_domain().is_empty()) { | |||
There was a problem hiding this comment.
This was wrong, and not caught sooner b/c I didn't loop over both false & true in the unit-test code.
The is-empty check is done in both callers of this method.
|
@nguyenv ready for round two! :) |
johnkerl
force-pushed
the
kerl/ut-generate
branch
from
a2bb0d0
to
cff1925
Compare
johnkerl
changed the title
johnkerl
force-pushed
the
kerl/ut-generate
branch
from
cff1925
to
d66d775
Compare
johnkerl
force-pushed
the
kerl/ut-generate
branch
from
d66d775
to
a3bf767
Compare
nguyenv
approved these changes
Sep 27, 2024
|
Thanks @nguyenv ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
For various debugs a while back I'd apparently left some Catch2 flags to on or off vs. looping over both. This PR fixes those overssights.
Notes for Reviewer: