Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testing] bump etcd v3.3.19 #41

Closed
wants to merge 47 commits into from
Closed

[testing] bump etcd v3.3.19 #41

wants to merge 47 commits into from

Conversation

hexfusion
Copy link

@hexfusion hexfusion commented Mar 20, 2020 •
edited
Loading

This PR bumps 4.3 from v3.3.17 to v3.3.19 which includes important stability fixes.

v3.3.18 details #21
v3.3.19 details #40

YoyinZyc and others added 30 commits October 11, 2019 11:27
@YoyinZyc
scripts: avoid release builds on darwin machine.
ffcddac
@gyuho
Merge pull request etcd-io#11245 from YoyinZyc/prevent-darwin-build-3.3
660dc83 
scripts: avoid release builds on darwin machine.
@jpbetz @YoyinZyc
Add version, tag and branch checks to release script
683a643
@gyuho @wenjiaswe
etcdserver/*: add "etcd_cluster_version" metric
5c19bd2 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho @wenjiaswe
tests/e2e: test cluster version
7fbfdc2 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@wenjiaswe
Add cluster version fix etcd-io#11233, etcd-io#11254, etcd-io#11265
e788880
@gyuho
Merge pull request etcd-io#11261 from wenjiaswe/automated-cherry-pick…
aedfe54 
…-of-#10257-upstream-release-3.3

cherry pick "etcd_cluster_version" metric" (etcd-io#10257, etcd-io#11233, etcd-io#11254, etcd-io#11265) to release-3.3
@gyuho
Merge pull request etcd-io#11253 from YoyinZyc/automated-cherry-pick-…
a977795 
…of-#11247-origin-release-3.3

Automated cherry pick of etcd-io#11247
@gyuho
scripts/release: list GPG key only when tagging is needed
ff5fb05 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@jingyih
etcdserver: wait purge file loop during shutdown
7c164a8 
To prevent the purge file loop from accidentally acquiring the file lock
and remove the files during server shutdowm.
@gyuho
Merge pull request etcd-io#11314 from jingyih/automated-cherry-pick-o…
069bce1 
…f-#11308-upstream-release-3.3

Automated cherry pick of etcd-io#11308 on release-3.3
@gyuho
clientv3: fix retry/streamer error message
5cf80a6 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@horkhe @jingyih
etcdserver: Remove infinite loop in doSerialize
95095f8 
Once chk(ai) fails with auth.ErrAuthOldRevision it will always do,
regardless how many times you retry. So the error is better be returned
to fail the pending request and make the client re-authenticate.
@jingyih
etcdserver: remove auth validation loop
5a48217 
Remove auth validation loop in v3_server.raftRequest(). Re-validation
when error ErrAuthOldRevision occurs should be handled on client side.
@jingyih
integration: disable TestV3AuthOldRevConcurrent
e1508f9 
Disable TestV3AuthOldRevConcurrent for now. See
etcd-io#10468 (comment)
@YoyinZyc @jingyih
mvcc: add "etcd_mvcc_put_size_in_bytes" to monitor the throughput of …
aaa8571 
…put request.
@YoyinZyc @jingyih
mvcc: update to "etcd_debugging_mvcc_total_put_size_in_bytes"
47d3dea
@wenjiaswe
Merge pull request etcd-io#11394 from jingyih/automated-cherry-pick-o…
9cd3eef 
…f-#11374-upstream-release-3.3

Automated cherry pick of etcd-io#11374 on release 3.3
@gyuho
version: 3.3.18
3c8740a 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@mitake
Merge pull request etcd-io#11378 from jingyih/automated-cherry-pick-o…
70853d6 
…f-#10218-etcd-io#10468-upstream-release-3.3

Automated cherry pick of etcd-io#10218 etcd-io#10468 on release 3.3
@jpbetz
mvcc/backend: Delete orphaned db.tmp files before defrag
b3d9e29
@wenjiaswe
Merge pull request etcd-io#11623 from jpbetz/automated-cherry-pick-of…
b0a4038 
…-#11613-origin-release-3.3

Automated cherry pick of etcd-io#11613 to release-3.3
@jingyih
mvcc/backend: check for nil boltOpenOptions
7b1a92c 
Check if boltOpenOptions is nil before use it.
@jingyih
Merge pull request etcd-io#11632 from jingyih/automated-cherry-pick-o…
e21e355 
…f-#11630-upstream-release-3.3

Automated cherry pick of etcd-io#11630 to release-3.3
@jingyih
etcdctl: fix member add command
c58133b 
Use members information from member add response, which is
guaranteed to be up to date.
@spzala
Merge pull request etcd-io#11665 from jingyih/automated-cherry-pick-o…
eb1df6d 
…f-#11638-upstream-release-3.3

Automated cherry pick of etcd-io#11638 on release-3.3
@hexfusion
proxy/grpcproxy: add return on error for metrics handler
1228d6c 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@gyuho
etcdserver/api/etcdhttp: log server-side /health checks
30aaceb 
ref.
etcd-io#11704

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
clientv3: embed api version in metadata
6f7ee07 
ref.
etcd-io#11687

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>

clientv3: fix racy writes to context key

=== RUN   TestWatchOverlapContextCancel

==================

WARNING: DATA RACE

Write at 0x00c42110dd40 by goroutine 99:

  runtime.mapassign()

      /usr/local/go/src/runtime/hashmap.go:485 +0x0

  github.com/coreos/etcd/clientv3.metadataSet()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/ctx.go:61 +0x8c

  github.com/coreos/etcd/clientv3.withVersion()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/ctx.go:47 +0x137

  github.com/coreos/etcd/clientv3.newStreamClientInterceptor.func1()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/client.go:309 +0x81

  google.golang.org/grpc.NewClientStream()

      /go/src/github.com/coreos/etcd/gopath/src/google.golang.org/grpc/stream.go:101 +0x10e

  github.com/coreos/etcd/etcdserver/etcdserverpb.(*watchClient).Watch()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/etcdserver/etcdserverpb/rpc.pb.go:3193 +0xe9

  github.com/coreos/etcd/clientv3.(*watchGrpcStream).openWatchClient()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:788 +0x143

  github.com/coreos/etcd/clientv3.(*watchGrpcStream).newWatchClient()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:700 +0x5c3

  github.com/coreos/etcd/clientv3.(*watchGrpcStream).run()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:431 +0x12b

Previous read at 0x00c42110dd40 by goroutine 130:

  reflect.maplen()

      /usr/local/go/src/runtime/hashmap.go:1165 +0x0

  reflect.Value.MapKeys()

      /usr/local/go/src/reflect/value.go:1090 +0x43b

  fmt.(*pp).printValue()

      /usr/local/go/src/fmt/print.go:741 +0x1885

  fmt.(*pp).printArg()

      /usr/local/go/src/fmt/print.go:682 +0x1b1

  fmt.(*pp).doPrintf()

      /usr/local/go/src/fmt/print.go:998 +0x1cad

  fmt.Sprintf()

      /usr/local/go/src/fmt/print.go:196 +0x77

  github.com/coreos/etcd/clientv3.streamKeyFromCtx()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:825 +0xc8

  github.com/coreos/etcd/clientv3.(*watcher).Watch()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:265 +0x426

  github.com/coreos/etcd/clientv3/integration.testWatchOverlapContextCancel.func1()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/integration/watch_test.go:959 +0x23e

Goroutine 99 (running) created at:

  github.com/coreos/etcd/clientv3.(*watcher).newWatcherGrpcStream()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:236 +0x59d

  github.com/coreos/etcd/clientv3.(*watcher).Watch()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/watch.go:278 +0xbb6

  github.com/coreos/etcd/clientv3/integration.testWatchOverlapContextCancel.func1()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/integration/watch_test.go:959 +0x23e

Goroutine 130 (running) created at:

  github.com/coreos/etcd/clientv3/integration.testWatchOverlapContextCancel()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/integration/watch_test.go:979 +0x76d

  github.com/coreos/etcd/clientv3/integration.TestWatchOverlapContextCancel()

      /go/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/integration/watch_test.go:922 +0x44

  testing.tRunner()

      /usr/local/go/src/testing/testing.go:657 +0x107

==================

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
etcdserver/api/v3rpc: handle api version metadata, add metrics
d9027ce 
ref.
etcd-io#11687

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
wking and others added 7 commits March 20, 2020 21:01
@wking @hexfusion
Dockerfile.*: Fix "etcd is distributed" -> "etcd is a distributed"
902f685 
Correcting a typo from 2f10964 (version: openshift-v4.0, 2018-11-29).
@hexfusion
Dockerfile: resolve issue where binary was not properly copied from b…
809c70c 
…uild.

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
OWNERS: add
b63a50b 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Dockerfile: set coreos org as canonical for release-3.3
2a80984 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Dockerfile: bump golang to 1.11
7726838 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Dockerfile: use build instead of make build
50867fd 
make build performs a sanity test on the binary image which causes problems for unsupport arch. Because we run full CI tests against the image this check is not nessisary and will allow images to be build regardless of arch.

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Dockerfile: bump golang 1.12
03d18ef 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion hexfusion force-pushed the openshift-4.3-bump-etcd-v3.3.19 branch from e5647b4 to 03d18ef Compare March 21, 2020 01:01
@hexfusion
Copy link
Author

/test all

@hexfusion
Copy link
Author

cc @deads2k @smarterclayton @abhinavdahiya @sdodson @crawford

@alaypatel07
Copy link

/retitle [openshift-4.3] Bug 1812262: bump etcd v3.3.19

@openshift-ci-robot openshift-ci-robot changed the title [openshift-4.3] Bug 1815638: bump etcd v3.3.19 [openshift-4.3] Bug 1812262: bump etcd v3.3.19 Apr 3, 2020
@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1812262, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.5.0" instead
  • expected Bugzilla bug 1812262 to depend on a bug targeting the "4.4.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[openshift-4.3] Bug 1812262: bump etcd v3.3.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alaypatel07
Copy link

/retitle [openshift-4.3] Bug 1815634: bump etcd v3.3.19

@openshift-ci-robot openshift-ci-robot changed the title [openshift-4.3] Bug 1812262: bump etcd v3.3.19 [openshift-4.3] Bug 1815634: bump etcd v3.3.19 Apr 3, 2020
@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1815634, which is invalid:

  • expected dependent Bugzilla bug 1815646 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead
  • expected dependent Bugzilla bug 1815646 to target the "4.4.0" release, but it targets "4.2.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[openshift-4.3] Bug 1815634: bump etcd v3.3.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@retroflexer
Copy link

/bugzilla refresh

@openshift-ci-robot
Copy link

@retroflexer: This pull request references Bugzilla bug 1815634, which is invalid:

  • expected dependent Bugzilla bug 1815646 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
  • expected dependent Bugzilla bug 1815646 to target a release in 4.4.0, 4.4.z, but it targets "4.2.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@retroflexer
Copy link

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 15, 2020
@openshift-ci-robot
Copy link

@retroflexer: This pull request references Bugzilla bug 1815634, which is valid.

8 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1801196 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent bug Bugzilla bug 1801237 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1801196 targets the "4.4.0" release, which is one of the valid target releases: 4.4.0, 4.4.z
  • dependent Bugzilla bug 1801237 targets the "4.4.0" release, which is one of the valid target releases: 4.4.0, 4.4.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2020
@hexfusion
Copy link
Author

continued #53

@hexfusion hexfusion closed this Jul 15, 2020
@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1815634. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

[openshift-4.3] Bug 1815634: bump etcd v3.3.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion changed the title [openshift-4.3] Bug 1815634: bump etcd v3.3.19 [testing] bump etcd v3.3.19 Jul 15, 2020
@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 15, 2020
@openshift-ci-robot
Copy link

@hexfusion: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[testing] bump etcd v3.3.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crawford crawford Awaiting requested review from crawford

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.