-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version, tag and branch checks to release script #11247
Conversation
@YoyinZyc would you do a review pass on this as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Thanks Joe!
for IMAGE in "quay.io/coreos/etcd:${RELEASE_VERSION}" "gcr.io/etcd-development/etcd:${RELEASE_VERSION}"; do | ||
local image_version=$(docker run --rm "${IMAGE}" etcd --version | grep "etcd Version" | awk -F: '{print $2}' | tr -d '[:space:]') | ||
if [ "${image_version}" != "${VERSION}" ]; then | ||
echo "Check failed: etcd --version output for ${IMAGE} is incorrect: ${image_version}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After finding out wrong image, can we remove it right away?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d rather not. There are the production release builds. Deleting from them automatically comes with significant risk. If the script reports that they have the wrong version, I’d like a human to intervene and sort out what happened.
LGTM, Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thx
@YoyinZyc Can you help backport next week? Thx. |
…47-origin-release-3.3 Automated cherry pick of #11247
…47-origin-release-3.4 Automated cherry pick of #11247
Improve checks in release script to prevent mistakes like the one I made in the etcd 3.3.16 release (#11241)
etcd --version
and check that it reports the correct version.etcd --version
and check that it reports the correct versionFixes #11241