Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdserver: unset old cluster version in metrics #11233

Merged
merged 1 commit into from
Oct 12, 2019
Merged

etcdserver: unset old cluster version in metrics #11233

merged 1 commit into from
Oct 12, 2019

Conversation

jingyih
Copy link
Contributor

@jingyih jingyih commented Oct 10, 2019

Fixes #11232.

@jingyih jingyih requested a review from gyuho October 10, 2019 20:26
@jingyih jingyih force-pushed the unset_old_cluster_version_metrics branch from c46460b to 9c4194f Compare October 12, 2019 05:26
gyuho
gyuho approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx!

Can we backport as well?

@gyuho gyuho merged commit f20daa5 into etcd-io:master Oct 12, 2019
@jingyih jingyih mentioned this pull request Oct 15, 2019
Merged
gyuho added a commit that referenced this pull request Oct 15, 2019
@gyuho
Merge pull request #11255 from jingyih/automated-cherry-pick-of-#11233-…
b3329eb 
…#11254-upstream-release-3.4

Automated cherry pick of #11233 #11254 on release 3.4
wenjiaswe added a commit to wenjiaswe/etcd that referenced this pull request Oct 16, 2019
@wenjiaswe
Add cluster version fix etcd-io#11233 and etcd-io#11254
980336f
wenjiaswe added a commit to wenjiaswe/etcd that referenced this pull request Oct 16, 2019
@wenjiaswe
Add cluster version fix etcd-io#11233 and etcd-io#11254
0ffb541
wenjiaswe added a commit to wenjiaswe/etcd that referenced this pull request Oct 16, 2019
@wenjiaswe
Add cluster version fix etcd-io#11233 and etcd-io#11254
3a343bc
wenjiaswe added a commit to wenjiaswe/etcd that referenced this pull request Oct 16, 2019
@wenjiaswe
Add cluster version fix etcd-io#11233 and etcd-io#11254
a4793be
wenjiaswe added a commit to wenjiaswe/etcd that referenced this pull request Oct 16, 2019
@wenjiaswe
Add cluster version fix etcd-io#11233 and etcd-io#11254
3fc4cc3
wenjiaswe added a commit to wenjiaswe/etcd that referenced this pull request Oct 16, 2019
@wenjiaswe
Add cluster version fix etcd-io#11233, etcd-io#11254, etcd-io#11265
e788880
gyuho added a commit that referenced this pull request Oct 17, 2019
@gyuho
Merge pull request #11261 from wenjiaswe/automated-cherry-pick-of-#10…
aedfe54 
…257-upstream-release-3.3

cherry pick "etcd_cluster_version" metric" (#10257, #11233, #11254, #11265) to release-3.3
wenjiaswe added a commit to wenjiaswe/etcd that referenced this pull request Oct 17, 2019
@wenjiaswe
Add cluster version fix etcd-io#11233, etcd-io#11254, etcd-io#11265
fc5f941
@wenjiaswe wenjiaswe mentioned this pull request Oct 17, 2019
Merged
gyuho added a commit that referenced this pull request Oct 17, 2019
@gyuho
Merge pull request #11271 from wenjiaswe/automated-cherry-pick-of-#11…
db9f5b0 
…261-upstream-release-3.2

cherry pick "etcd_cluster_version" metric" (#10257, #11233, #11254, #11265) to release-3.2
hexfusion pushed a commit to openshift/etcd that referenced this pull request Mar 20, 2020
@wenjiaswe @hexfusion
Add cluster version fix etcd-io#11233, etcd-io#11254, etcd-io#11265
1290ca2
hexfusion pushed a commit to openshift/etcd that referenced this pull request Mar 21, 2020
@wenjiaswe @hexfusion
Add cluster version fix etcd-io#11233, etcd-io#11254, etcd-io#11265
c544ca5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oldthreefeng oldthreefeng oldthreefeng left review comments

@gyuho gyuho gyuho approved these changes

Assignees
No one assigned
Labels
backport/v3.4
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 cluster versions
3 participants
@jingyih @gyuho @oldthreefeng