Automated cherry pick of #10218 #10468 on release 3.3 #11378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once chk(ai) fails with auth.ErrAuthOldRevision it will always do, regardless how many times you retry. So the error is better be returned to fail the pending request and make the client re-authenticate.
Remove auth validation loop in v3_server.raftRequest(). Re-validation when error ErrAuthOldRevision occurs should be handled on client side.
Disable TestV3AuthOldRevConcurrent for now. See etcd-io#10468 (comment)
jingyih
changed the title
jingyih
deleted the
automated-cherry-pick-of-#10218-#10468-upstream-release-3.3
branch
|
Hey @jingyih, could you provide some context on why this wasn't merged? |
jingyih
restored the
automated-cherry-pick-of-#10218-#10468-upstream-release-3.3
branch
My guess is that I accidentally deleted the branch which caused this PR to be closed. |
|
@jingyih sorry for my late reply. LGTM, thanks! I'm merging this, the test case |
jingyih
deleted the
automated-cherry-pick-of-#10218-#10468-upstream-release-3.3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #10218 #10468 on release-3.3.
#10218: etcdserver: Remove infinite loop in doSerialize
#10468: etcdserver: remove auth validation loop
Fixes #11377