-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify the user when debug is blocked on prelaunch tasks #218267
Comments
This is probably because a prelaunch task is still running / your problem matchers haven't matched anything. Please make sure you have the right problem matchers installed, otherwise I suggest opening issues for them if they don't match correctly. |
Would be great if debug could give me a hint. |
Will keep open to track it, it's not a rare problem |
We should also keep the terminal open if the task fails, currently it closes immediately which can be confusing |
Would also be nice if we could cancel the pending launch attempt, e.g. by showing the debug toolbar immediately and disabling all buttons except the stop button. Right now when I get into this state I end up just reloading the whole window and incurring the pain of all extensions reactivating, which takes several seconds on my machine (git, TS etc) |
Shows this notification if a prelaunch task has been running for more than 10 seconds: ![](https://memes.peet.io/img/24-07-be15cd9d-c9cd-40dc-8937-9d62466e5c96.png) Also does a little cleanup of some probably-leaking disposables in the task runner. Fixes #218267
* debug: improve behavior for slow-running prelaunch tasks Shows this notification if a prelaunch task has been running for more than 10 seconds: ![](https://memes.peet.io/img/24-07-be15cd9d-c9cd-40dc-8937-9d62466e5c96.png) Also does a little cleanup of some probably-leaking disposables in the task runner. Fixes #218267 * hygenie * editor: fix glyph margin links not working The constructor was missing decorations, so _openingService was always undefined and links did not open. Fixes #214786 cc @aiday-mar
Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the |
* debug: improve behavior for slow-running prelaunch tasks Shows this notification if a prelaunch task has been running for more than 10 seconds: ![](https://memes.peet.io/img/24-07-be15cd9d-c9cd-40dc-8937-9d62466e5c96.png) Also does a little cleanup of some probably-leaking disposables in the task runner. Fixes #218267 * hygenie * dom: make SafeTriangle smaller, add tests
|
* debug: improve behavior for slow-running prelaunch tasks Shows this notification if a prelaunch task has been running for more than 10 seconds: ![](https://memes.peet.io/img/24-07-be15cd9d-c9cd-40dc-8937-9d62466e5c96.png) Also does a little cleanup of some probably-leaking disposables in the task runner. Fixes #218267 * hygenie * debug/variables: autofill input from an LRU This keeps a small LRU in the config resolver and storage service to provide default values, when not otherwise specified, for inputs in e.g. debugging. I added this after I was annoyed by having to keep autofilling the same ephemeral value in some debug configs earlier.
* debug: improve behavior for slow-running prelaunch tasks Shows this notification if a prelaunch task has been running for more than 10 seconds: ![](https://memes.peet.io/img/24-07-be15cd9d-c9cd-40dc-8937-9d62466e5c96.png) Also does a little cleanup of some probably-leaking disposables in the task runner. Fixes microsoft#218267 * hygenie * debug/variables: autofill input from an LRU This keeps a small LRU in the config resolver and storage service to provide default values, when not otherwise specified, for inputs in e.g. debugging. I added this after I was annoyed by having to keep autofilling the same ephemeral value in some debug configs earlier.
Clone https://github.com/microsoft/vscode-dev and npm install. Hit F5, it never starts:
I am on macOS.
The text was updated successfully, but these errors were encountered: