Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dom: make SafeTriangle smaller, add tests #224401

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

connor4312
Copy link
Member

No description provided.

Shows this notification if a prelaunch task has been running for more
than 10 seconds:

![](https://memes.peet.io/img/24-07-be15cd9d-c9cd-40dc-8937-9d62466e5c96.png)

Also does a little cleanup of some probably-leaking disposables in the task runner.

Fixes #218267
@connor4312 connor4312 self-assigned this Jul 31, 2024
@connor4312 connor4312 enabled auto-merge (squash) July 31, 2024 16:15
@vscodenpa vscodenpa added this to the August 2024 milestone Jul 31, 2024
@bpasero
Copy link
Member

bpasero commented Jul 31, 2024

Learned something 📐

@connor4312 connor4312 merged commit 6f2764a into main Jul 31, 2024
7 checks passed
@connor4312 connor4312 deleted the connor4312/better-safe-triangle branch July 31, 2024 16:31
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants