Skip to content

Commit

Permalink
editor: fix glyph margin links not working (#224352)
Browse files Browse the repository at this point in the history
* debug: improve behavior for slow-running prelaunch tasks

Shows this notification if a prelaunch task has been running for more
than 10 seconds:

![](https://memes.peet.io/img/24-07-be15cd9d-c9cd-40dc-8937-9d62466e5c96.png)

Also does a little cleanup of some probably-leaking disposables in the task runner.

Fixes #218267

* hygenie

* editor: fix glyph margin links not working

The constructor was missing decorations, so _openingService was always undefined and links did not open.

Fixes #214786

cc @aiday-mar
  • Loading branch information
connor4312 authored Jul 31, 2024
1 parent 85fe3e7 commit f7deb0a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/vs/editor/contrib/hover/browser/marginHoverWidget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ export class MarginHoverWidget extends Disposable implements IOverlayWidget, IHo

constructor(
editor: ICodeEditor,
languageService: ILanguageService,
openerService: IOpenerService,
@ILanguageService languageService: ILanguageService,
@IOpenerService openerService: IOpenerService,
) {
super();
this._editor = editor;
Expand Down

0 comments on commit f7deb0a

Please sign in to comment.