Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workspace draft build #5795

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix: workspace draft build #5795

merged 1 commit into from
Oct 10, 2024

Conversation

rahulramesha
Copy link
Collaborator

@rahulramesha rahulramesha commented Oct 10, 2024

This PR is a patch to fix the build caused by workspace drafts changes

Summary by CodeRabbit

  • New Features

    • Enhanced issue management with new quick action options and improved drag-and-drop functionality.
    • Added flexibility in issue creation and updates to support multiple issue types.
    • Introduced new methods for managing issues within cycles and modules.
  • Bug Fixes

    • Improved type safety and clarity in issue creation and update processes.
  • Documentation

    • Updated component display names for better clarity.
  • Chores

    • Reorganized import statements for improved readability.

Copy link
Contributor

coderabbitai bot commented Oct 10, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces various modifications across multiple components and services related to issue management. Key changes include the addition of new props in the WorkspaceDraftIssueLayoutRoot component, updates to issue handling methods in the CreateUpdateIssueModalBase, enhancements to the ColorDropdown component, and the introduction of new types and methods in various hooks and services. These changes collectively aim to improve the functionality and maintainability of the issue management system.

Changes

File Path Change Summary
.../workspace-draft-root.tsx Added QuickActions and canEditPropertiesBasedOnProject props to BaseListRoot.
.../issue-modal/base.tsx Updated issue creation and updating methods with refined logic and type definitions.
.../header/color-dropdown.tsx Added display name for ColorDropdown and adjusted import statements for readability.
.../use-group-dragndrop.ts Added EIssuesStoreType.WORKSPACE_DRAFT to DNDStoreType.
.../use-issues-actions.tsx Updated fetching and issue management methods to use new pagination type and generalized methods.
.../workspace_draft.service.ts Updated createIssue and updateIssue methods to accept `Partial<TWorkspaceDraftIssue
.../issue/root.store.ts Reformatted import statements in IssueRootStore for better readability.
.../workspace-draft/issue.store.ts Modified IWorkspaceDraftIssues interface and WorkspaceDraftIssues class with new methods and types.

Possibly related PRs

Suggested labels

🧹chore, 🐛bug

Suggested reviewers

  • SatishGandham

🐰 In the code we hop and play,
New props and methods lead the way.
With each change, our bugs take flight,
Drafts and issues shine so bright!
A joyful leap, a coding cheer,
For every fix, we hold so dear! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pushya22 pushya22 merged commit 9c2278a into preview Oct 10, 2024
10 of 13 checks passed
@pushya22 pushya22 deleted the fix-workspace-draft-build branch October 10, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants