-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: cycles build issue #5750
Fix: cycles build issue #5750
Conversation
WalkthroughThe changes in this pull request involve modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
web/core/components/cycles/list/root.tsx (1)
31-31
: LGTM! Consider destructuring props for consistency.The addition of
workspaceSlug
andprojectId
props toActiveCycleRoot
aligns with the PR objective and should resolve the build issue. This change provides necessary context to the component, improving its functionality.For consistency with other parts of the file, consider destructuring these props:
-<ActiveCycleRoot workspaceSlug={workspaceSlug} projectId={projectId} /> +<ActiveCycleRoot {...{ workspaceSlug, projectId }} />This minor change would make the code more consistent with how props are passed to other components in this file.
Summary
Fixed build issue in active cycle root component
Summary by CodeRabbit
New Features
CyclesList
component to provide context by passingworkspaceSlug
andprojectId
to theActiveCycleRoot
component.Bug Fixes
ActiveCycleRoot
.