[WEB 2418] Fix minor UI inconsistencies

[gakshita]

Summary

• Module dropdown padding fixed
• Cycle info box position fixed

[WEB 2418]

Summary by CodeRabbit

• New Features

  • Enhanced styling options for dropdown items and button content, allowing for better customization.
  • Introduced a new itemClassName property in the IssueModuleSelect component for improved dropdown item styling.
  • Updated layout structure in the ProjectFeatureUpdate component for better visual alignment using a new component.

• Bug Fixes

  • Improved visual spacing in the ProjectFeaturesList component by adjusting padding.

• Style

  • Enhanced layout and styling capabilities across various components for a more polished user interface.

[coderabbitai]

Walkthrough

This pull request introduces several modifications across various components, primarily focusing on enhancing styling and layout capabilities. Key changes include the addition of new properties for class name customization in dropdown components, the use of a Row component for improved layout in the ProjectFeatureUpdate, and minor adjustments to padding in the ProjectFeaturesList. Overall, the changes aim to improve the visual presentation and flexibility of the components without altering their core functionality.

Changes

File	Change Summary
web/core/components/cycles/list/root.tsx	Added className="flex-row" to the ContentWrapper in the CyclesList component to enhance layout styling.
web/core/components/dropdowns/module/index.tsx	Introduced itemClassName to Props and className to ButtonContentProps, allowing for customizable styling in dropdown items and button content.
web/core/components/issues/issue-detail/module-select.tsx	Added itemClassName property set to "px-2" in the IssueModuleSelect component for improved dropdown item styling.
web/core/components/project/project-feature-update.tsx	Replaced <div> with <Row> from @plane/ui to enhance layout structure in the ProjectFeatureUpdate component.
web/core/components/project/settings/features-list.tsx	Added pb-2 class to a <div> in the ProjectFeaturesList to adjust bottom padding for better visual spacing.
web/core/store/issue/issue.store.ts	Repositioned the import of the update function from lodash to the top of the import section without affecting functionality.

Possibly related PRs

• [WEB-2416] Fix: project features modal padding #5562: The changes in this PR involve modifications to the layout and styling of components in the same area of the codebase, specifically affecting the ProjectFeatureUpdate component, which may relate to the overall visual presentation improvements similar to the changes made in the main PR.

Poem

🐰 In the meadow where changes bloom,
New styles dance, dispelling gloom.
Buttons and dropdowns, all dressed bright,
With class names added, they take flight!
Hops of joy for features anew,
A rabbit's cheer for the code crew! 🌼✨

Tip

Announcements

• The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment.
• We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.
• Possibly related PRs: Walkthrough comment now includes a list of potentially related PRs to help you recall past context. Please share any feedback in the discussion post on our Discord.
• Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs in the walkthrough comment. You can also provide custom labeling instructions in the UI or configuration file.
• Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f5143da and f179e73.

Files selected for processing (1)

• web/core/store/issue/issue.store.ts (1 hunks)

Files skipped from review due to trivial changes (1)

• web/core/store/issue/issue.store.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 99a7867 and f5143da.

Files selected for processing (5)

• web/core/components/cycles/list/root.tsx (1 hunks)
• web/core/components/dropdowns/module/index.tsx (6 hunks)
• web/core/components/issues/issue-detail/module-select.tsx (1 hunks)
• web/core/components/project/project-feature-update.tsx (2 hunks)
• web/core/components/project/settings/features-list.tsx (1 hunks)

Files skipped from review due to trivial changes (3)

• web/core/components/cycles/list/root.tsx
• web/core/components/issues/issue-detail/module-select.tsx
• web/core/components/project/settings/features-list.tsx

Additional comments not posted (2)

web/core/components/project/project-feature-update.tsx (1)

7-7: Good use of the <Row> component for layout enhancement.

The replacement of a <div> with a <Row> component is a positive change for better layout management. However, ensure that the class name py-6 is consistent with the desired styling and spacing within the component.

Run the following script to verify the impact of the class name py-6 on the layout:

Also applies to: 31-33

Verification successful

---

Consistent usage of py-6 class across components confirms intended styling.

The class name py-6 is consistently used across various components, indicating it is a standard utility class for vertical padding. This aligns with the intended styling and spacing within the component, confirming the review comment's suggestion to verify its impact on layout. No further action is needed.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the impact of the class name `py-6` on the layout.

# Test: Search for the class name usage. Expect: Consistent usage across components.
rg --type typescript -A 5 $'py-6'

Length of output: 67

---

Script:

#!/bin/bash
# Description: Verify the impact of the class name `py-6` on the layout.

# Test: Search for the class name usage. Expect: Consistent usage across components.
rg --type tsx -A 5 $'py-6'

Length of output: 53

---

Script:

#!/bin/bash
# Description: Verify the impact of the class name `py-6` on the layout.

# Find all .tsx files and search for the class name usage within them.
fd --extension tsx --exec rg 'py-6' {}

Length of output: 1584

web/core/components/dropdowns/module/index.tsx (1)

30-30: Enhanced styling flexibility with new class name properties.

The addition of itemClassName and className properties is a positive change, allowing for more customized styling of dropdown components. Ensure that these properties are optional and verify that their introduction does not affect existing components negatively.

Run the following script to verify the impact of the new properties on existing components:

Also applies to: 55-55, 70-70, 99-102, 168-168, 280-280