-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Media field: selectable folders #43579
Conversation
@Fedik you could probably patch also this event: joomla-cms/administrator/components/com_media/resources/scripts/components/tree/tree.vue Line 85 in dfb572d
So selecting a folder on the left (disk/folder tree) could be also a valid way to select the folder |
@brianteeman I forgot it exists, should be good now. |
Is it possible to use something other than "types" as I am sure people will confuse it with "type" |
That would be a b/c break so no |
Nope, unfortunately. It is what we already use
For the Media field. |
ok fair enough. I searched for ;) |
I also updated TinyMCE upload directory for "drag and drop", to use this feature. |
Co-authored-by: Quy <quy@nomonkeybiz.com>
Nice work. I tested it with DPMedia and the FTP plugin, unfortunately when I select a folder from the FTP adapter, the field stays empty in the media custom field. |
@laoneo is right, this approach will never work for anything else other than the local filesystem. Maybe having |
Thanks for checking. I did not have a time to test with external adapters, and expected it works. |
There is a free version of DPMedia with the FTP adapter if you want to try it by yourself. |
I have update PR, now the folder should be also selectable on "double click". |
This worked perfectly, also with navigation into another folder and with other adapters than the local one. |
I have tested this item ✅ successfully on 3223f82 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43579. |
I have tested this item ✅ successfully on 3223f82 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43579. |
1 similar comment
I have tested this item ✅ successfully on 3223f82 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43579. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43579. |
This feature is nice and I will merge it as soon as drone has passed. One thing which I find strange however is, that you can set it to a subfolder, but then you can still move up the folders and select a different folder. This is also present in the current implementation, but if I set it to folder X, I wouldn't expect to be able to upload in a parent folder of that. |
Thanks @Fedik for your contribution. :-) |
joomla/joomla-cms#43232 + joomla/joomla-cms#43378 + joomla/joomla-cms#43216 + joomla/joomla-cms#43260 + joomla/joomla-cms#43386 + joomla/joomla-cms#43575 + joomla/joomla-cms#43491 + joomla/joomla-cms#43760 - (upmerge, внесено в 5.1х) joomla/joomla-cms#43247 + joomla/joomla-cms#43579 + joomla/joomla-cms#43690 + joomla/joomla-cms#43829 + joomla/joomla-cms#43840 + joomla/joomla-cms#43841 + joomla/joomla-cms#43885 - (upmerge, только для др. пакетов) joomla/joomla-cms#43223 + joomla/joomla-cms#43810 - (только для en-GB) joomla/joomla-cms#43898 + joomla/joomla-cms#43432 + joomla/joomla-cms#43870 + joomla/joomla-cms#42850 + joomla/joomla-cms#43937 - (upmerge, только для др. пакетов) joomla/joomla-cms#43862 + joomla/joomla-cms#43975 + joomla/joomla-cms#43910 + joomla/joomla-cms#43965 + joomla/joomla-cms#43738 + joomla/joomla-cms#43814 + joomla/joomla-cms#44000 + joomla/joomla-cms#44050 + (upmerge, с 4.4.9) joomla/joomla-cms#43966 + joomla/joomla-cms#44065 +
Summary of Changes
The PR add posibility to select directories usign the Media field.
This is helpfull when the site have multiple Media adapters.
Testing Instructions
Run
npm install
.Create custom field Media,
Pick the directory in the "Directory" option.
Edit TinyMCE (plugin config) "Images Directory" (when "Images Drag and Drop" is On). And test TinyMCE drag and drop upload.
Actual result BEFORE applying this Pull Request
You able to pick only one of folder under
/images
Expected result AFTER applying this Pull Request
You can pick any directory that available in the Media manager
Link to documentations
Please select: