[5.2] Cleanup of return types for phpstan (#43350)

* Cleanup of return types

* Return nothing instead of an empty string

* Update OverridesModel.php

administrator/components/com_admin/script.php

@@ -3002,7 +3002,7 @@ private function migrateTinymceConfiguration(): bool
     /**
      * setup Guided Tours Unique Identifiers
      *
-     * @return  boolean  True on success
+     * @return  void
      *
      * @since   5.0.0
      */

administrator/components/com_categories/src/Model/CategoryModel.php

@@ -752,6 +752,8 @@ public function publish(&$pks, $value = 1)
 
             return true;
         }
+
+        return false;
     }
 
     /**

administrator/components/com_languages/src/Model/OverridesModel.php

@@ -233,7 +233,7 @@ public function delete($cids)
     /**
      * Removes all of the cached strings from the table.
      *
-     * @return  boolean  result of operation
+     * @return  void|\RuntimeException
      *
      * @since   3.4.2
      */

administrator/components/com_menus/src/Controller/MenuController.php

@@ -180,6 +180,8 @@ public function save($key = null, $urlVar = null)
                 $this->setRedirect(Route::_('index.php?option=com_menus&view=menus', false));
                 break;
         }
+
+        return true;
     }
 
     /**

administrator/components/com_modules/src/Controller/ModuleController.php

@@ -258,7 +258,7 @@ public function save($key = null, $urlVar = null)
     /**
      * Method to get the other modules in the same position
      *
-     * @return  string  The data for the Ajax request.
+     * @return  void
      *
      * @since   3.6.3
      */
@@ -303,7 +303,7 @@ public function orderPosition()
         } catch (\RuntimeException $e) {
             $app->enqueueMessage($e->getMessage(), 'error');
 
-            return '';
+            return;
         }
 
         $orders2 = [];