[5.2] Cleanup of return types for phpstan #43350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HLeithner
requested changes
Apr 25, 2024
administrator/components/com_modules/src/Controller/ModuleController.php
Show resolved
Hide resolved
richard67
approved these changes
May 29, 2024
pe7er
pushed a commit
that referenced
this pull request
Jun 4, 2024
* [5.2] Cleanup of return types for phpstan (#43350) * Cleanup of return types * Return nothing instead of an empty string * Update OverridesModel.php * [5.2] TinyMCE Accordion Since Joomla 5.0 we have shipped a version of tinyMCE that includes a plugin called accordion. However we never exposed it to our plugin so it was not available to use. This PR remedies that. New installs will see the accordion icon on the toolbar with the list icons For existing installs you will need to EITHER drag the icon into the toolbar in the plugin configuration OR if you havent changed the toolbar you can use the clear and the the use advanced preset buttons. Technically tinymce have misnamed the the plugin as it should not be confused with other accordion functionality such as the js based solution that can be enabled with bootstrap. This plugin implements the native html details/summary disclosure element which requires no javascript and is accessible out of the box. To test As this requires a js change either apply the pr and run `nmp ci` or use one of the prebuilt packages If it is a new install then the icon will now be able in the toolbar. If it is an upgrade then you will need to use the tinymce plugin editor to add it (as described above) * cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This cleans up a few false return statements.
Testing Instructions
Codereview
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed