[5.2] Languagefilter: Add message when no content language is published #43232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
Apr 8, 2024
Co-authored-by: Quy <quy@nomonkeybiz.com>
|
I have tested this item ✅ successfully on 4e5629b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43232. |
brianteeman
reviewed
Apr 8, 2024
|
I have tested this item ✅ successfully on 4e5629b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43232. |
richard67
reviewed
Apr 9, 2024
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
|
I have tested this item ✅ successfully on 352b86f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43232. |
1 similar comment
|
I have tested this item ✅ successfully on 352b86f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43232. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43232. |
|
txs @Hackwar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #41798 .
Summary of Changes
When you unpublish all content languages, but have the languagefilter system plugin enabled, the system is in an undefined state and different errors can show up. This PR adds a constant message to all pages that the administrator has to take action here.
Testing Instructions
Actual result BEFORE applying this Pull Request
See nothing, maybe PHP notices from the languagefilter plugin.
Expected result AFTER applying this Pull Request
See a message that the content languages are disabled and the languagefilter plugin is enabled.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed